Problem/Motivation

Projects can be filtered using 4 filters (category, security coverage, maintenance status, development status).

Visually, the first filter is not aligned with the others:

screenshot of project browser shoes misalignment of category filter

Steps to reproduce

Proposed resolution

CommentFileSizeAuthor
#8 Screenshot 2024-11-16 at 10.10.59 AM.png81.4 KBkyle.davis
#7 Screenshot 2024-11-15 154649.png17.69 KBericrubino
Filter-by-category-off-by-a-few-pixels.png199.21 KBmarkfelton

Issue fork project_browser-3487842

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

markfelton created an issue. See original summary.

markfelton’s picture

markfelton commented

While here, maybe check the capitalization of the filters
"Filter by category" is consistent with other filters in Core
but is the capitalization of "Maintenance Status" correct — should it be "Maintenance status" ?

kd_ace made their first commit to this issue’s fork.

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Issue tags: +core-mvp, +beta blocker

ericrubino made their first commit to this issue’s fork.

ericrubino opened merge request !615

ericrubino’s picture

ericrubino commented
StatusFileSize
new Screenshot 2024-11-15 154649.png17.69 KB

Corrected filters display by removing the fieldset. We discussed with Chris if we should remove the field set from the one field or add fieldsets to the other three filter items. We also located a single piece of CSS that set margins to 0 for this single item.

kyle.davis’s picture

kyle.davis commented
StatusFileSize
new Screenshot 2024-11-16 at 10.10.59 AM.png81.4 KB

Latest commits fix nightwatch test errors for filters on the browse page. Added rewrite of filter labels on the browse page to use sentence case. All tests passing now and MR is ready for review.

kyle.davis’s picture

kyle.davis commented
Status: Needs work » Needs review

chrisfromredfin’s picture

chrisfromredfin
he/him/his
Primary language English
Location Portland, Maine
commented
Status: Needs review » Fixed

Though a double-scoped issue, I'm happy to have it in. Thanks for your contributions here at NEDCamp!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.