Problem/Motivation
Some media could not be retrieved because the source is private or similar, oembed gives a message like "Could not retrieve the remote URL".
Proposed resolution
List the resources that can not be retrieved.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | status_report_external_resources.png | 35.99 KB | eduardo morales alberti |
| #4 | external_resources_needs_review.png | 62.65 KB | eduardo morales alberti |
| #4 | external_resources.png | 50.86 KB | eduardo morales alberti |
Issue fork xray_audit-3482085
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
eduardo morales albertiAfter talking with @tunic and @lpeidro we decided that this fits better on the submodule insights.
It will try to extract the error related or hook to the fetcher resource.
Comment #4
eduardo morales albertiReady to review https://git.drupalcode.org/project/xray_audit/-/merge_requests/74#note_4...
The strategy was to create a decorator that registers when a resource gives an exception, it saves on a xray_audit_insight table with the message and the url.
https://git.drupalcode.org/project/xray_audit/-/merge_requests/74/diffs#...
We also created a External Resources task on Content Display group.
If the module insight is enabled then it shows the resources that needs to be reviewed.

Also, if there there are resources to be reviewed it shows it on the status report:

Comment #5
eduardo morales albertiSolve all threads @tunic
Comment #6
tunicThanks, it looks good to me!
I would prefer to wait for comments from @lpeidro before committing this forward but I think it is ok to move it to RTBC.
Comment #7
eduardo morales albertiWe simplified the code and removed the table "xray_audit_insight", and we recalculated the external resources status on the xray audit and on the insights.
Comment #8
eduardo morales albertiWe will remove the insight as it takes to much time to process on the status report
Comment #9
eduardo morales albertiReady to review, we removed the insight to avoid excessive loads on status page
Comment #10
lpeidro commentedI change the develop branch (2.x-dev).
It is convenient to adapta the code to the new branch.
Comment #11
lpeidro commentedI have merged the Press Release. Thank you, Edu.