Problem/Motivation

Since working on this module last in #2708461: Port to Drupal 8/9, I've started using a new pattern for constructing dependency-injected classes which avoids some of the constructor complexity and backwards-compatibility concerns and also avoids the "unsafe usage of new static" PHPStan warning that's sometimes present in old code. I didn't invent it, but I don't know if it has a name.

Proposed resolution

Start using the new pattern. Make sure tests pass.

Remaining tasks

  1. Write a merge request
  2. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork feedback-3481980

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mparker17 created an issue. See original summary.

mparker17 opened merge request !5

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Status: Active » Reviewed & tested by the community

Seems to be passing tests locally.

  • mparker17 committed 547b627f on 3.x 
    Issue #3481980: Switch to new constructor/dependency-injection pattern
mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Assigned: mparker17 » Unassigned
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Looks good; merging.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.