Problem/Motivation

Now that we are using GitLab for testing we can easily enforce the Drupal coding standards.

Proposed resolution

We already have a job that checks coding standards, but it is currently only emitting a warning when the coding standards check fails. We can fix the coding standards, and update the job to fail the pipeline when new coding standards violations are introduced in MRs.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pfrenssen created an issue. See original summary.

pfrenssen’s picture

Status: Active » Needs review
pfrenssen’s picture

I'm going to merge this, I think the changes are harmless, and having this in will make it easier to work on the other open patches.

  • pfrenssen committed f1fba93b on 2.0.x
    Issue #3479843 by pfrenssen: Adhere to coding standards
    

  • pfrenssen committed 4a263372 on 3.0.x
    Issue #3479843 by pfrenssen: Adhere to coding standards
    
pfrenssen’s picture

Status: Needs review » Fixed

  • pfrenssen committed f1fba93b on 3.0.x
    Issue #3479843 by pfrenssen: Adhere to coding standards
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.