Problem/Motivation

Currently on the status report the xray_audit insight is shown submodules not enabled, maybe those modules can be ignored, as some contrib modules have multiples submodules that are optional and can not be removed.

Report example:

The following custom and/or contrib modules are not enabled (Modules Report):
Modules contrib not enabled:
Facets Range Widget, Rest Facets, Facets Searchbox Widget
CommentFileSizeAuthor
#2 example-submodule-no-project.png73.24 KBlpeidro

Issue fork xray_audit-3479115

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

lpeidro’s picture

StatusFileSize
new73.24 KB

There is a logic to exclude submodules by checking the project set in the info.yml, which does not seem to be effective in the case of the Facets module, where the project parameter is not set.

For example, if Webform is used in the project, the disabled submodules are not displayed.

It is necessary to review the logic to make it much more refined.

Sorry, in my initial judgment I was mistaken.

The issue lies in the fact that, as I mentioned, to check if it is a submodule or not, we were checking the module's project.

However, the project's info is not inserted by the contributor in the .info file, but is automatically added during the release generation process.

Therefore, in those cases where disabled submodules are shown, it is because the development version is installed instead of the release version.

It is necessary to review the logic to make it much more refined.

lpeidro’s picture

Assigned: Unassigned » lpeidro

An additional check has been added in case the project is not defined in the module, by verifying the module's path. However, this solution might still fail to detect some cases if the development version is installed. A 100% reliable logic would require a certain computational cost, which could be an inconvenience for Drupal status reports.

  • ffd9ecc9 committed on 1.x
    Issue #3479115: We add an aditional check to detect submodules by...
lpeidro’s picture

Status: Active » Fixed
eduardo morales alberti’s picture

Thank you @lpeidro

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.