Problem/Motivation
Currently, the insight reports list shows views using Solr as the backend.
Search_api sets the cache none to the views of type solr #3423063: Performance issue in cache plugin getRowId for Search API views with disabled cache , so those views can be ignored.
https://git.drupalcode.org/project/search_api/-/merge_requests/109/diffs...
Because Solr is an external backend to Drupal, the information displayed on the view could not be updated.
The solution could be to separate search API Solr views from the others on the report, as some sites could implement some valid cache type.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | ignore_views_insight.png | 59.51 KB | eduardo morales alberti |
Issue fork xray_audit-3479100
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
eduardo morales albertiComment #3
eduardo morales albertiComment #4
lpeidro commentedI think this request is very tied to the Search API Solr module, which is the context in which it's required that the view not be cached. Applying this kind of differentiation might contradict the purpose of the insight and the warnings we issue in it. In other words, it's ultimately a heads-up that there may be something that needs to be reviewed.
I’ll leave the issue open in case anyone else thinks it's necessary to make this distinction, especially from a usability perspective.
Comment #5
lpeidro commentedThere are many views generated by modules that are not cached because they are used to administer the site.
We are unable to exclude all of them by default since any module can create this type of view.
The best solution is to create a functionality that allows us to configure which views we want to exclude from the insights.
I change the title of the issue to implement this functionality.
Comment #6
lpeidro commentedComment #7
eduardo morales albertiAdded dependency with issue #3483405: Drop compatiblitiy with Drupal 9 version as some changes are not compatibles with drupal 9
Comment #9
eduardo morales albertiChanges made
Comment #10
lpeidro commented@edu Great job! I just refactored the code that determines if an Insight is active or not to ensure compatibility with the form alterations.