Make this module compatible with Drupal 11

CommentFileSizeAuthor
#10 Screenshot 2025-01-02 at 6.54.52 PM.png128.14 KBsheshsharma
#10 Screenshot 2025-01-02 at 6.55.10 PM.png118.63 KBsheshsharma

Issue fork taxonomy_access_fix-3470214

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

flyke created an issue. See original summary.

gowtham-unimity made their first commit to this issue’s fork.

gowtham-unimity opened merge request !12

gowtham-unimity’s picture

gowtham-unimity commented
Status: Active » Needs review
feyp’s picture

feyp commented
Status: Needs review » Needs work

Thanks for creating the issue. I can already say that the change of the main info.yml is not enough. Just run the tests once and you should see the problem. But we'll need a rebase anyway once I have enabled GitLab CI. I'm setting this to needs work for now for the rest of the required changes, but it is not a good time to work on it for now.

Also, the code changes are really straight forward and mostly covered by automated tools. What I could use help with is manual testing on all supported core versions once the changes are ready. Especially if you already use the module on D10 and would be willing to test an update to D11. But again: Soon, but not yet.

jeroent made their first commit to this issue’s fork.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review

I made some changes to the MR and fixed all coding standards issues and failing tests:
https://git.drupalcode.org/issue/taxonomy_access_fix-3470214/-/pipelines...

Only upgrade status is still showing a warning because we don't support Drupal 12 yet.

I also noticed that the tests were failing on 11.x-dev (as of 11.0.5) because of #3386313: The entity link label formatter should check URL access. So I had to make some changes to tests/src/Functional/VocabularyLabelAccessTest.php to fix the tests:
https://git.drupalcode.org/project/taxonomy_access_fix/-/merge_requests/...

feyp’s picture

feyp commented

Thanks.

Only upgrade status is still showing a warning because we don't support Drupal 12 yet.

This is expected, the job tests compatibility with D12 now. It can be ignored.

manishvaity’s picture

manishvaity commented

MR!12 Makes this module compatible with Drupal 11. Functionality is working as expected.

sheshsharma’s picture

sheshsharma commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot 2025-01-02 at 6.55.10 PM.png118.63 KB
new Screenshot 2025-01-02 at 6.54.52 PM.png128.14 KB

MR!12 Makes this module compatible with Drupal 11. Functionality is working as expected.
RTBC +1

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

Looks great, I hope we can commit the merge request from @jeroent. Especially since this also fixes the tests I think it should be committed.

To make it easier for people to upgrade, I think a new tagged release will be helpful as well.

voleger made their first commit to this issue’s fork.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Status: Reviewed & tested by the community » Fixed

Fixed, thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.