Problem/Motivation

In #3333202: Allow to add classes for external and mail links, config options for extlink_additional_link_settings and extlink_additional_mailto_settings landed in a hook update. But the names used are not what is used by the code. The names are extlink_additional_link_classes and extlink_additional_mailto_classes.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork extlink-3467662

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

heddn created an issue. See original summary.

heddn opened merge request !36

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Reviewed & tested by the community

Clearly correct. My mistake, that this has been merged with wrong variables. I must have missed that in one of the last steps. -.- SORRY!

  • Anybody committed d26978c2 on 2.0.x authored by heddn 
    Issue #3467662 by heddn: extlink_update_8103 for mailto...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

@heddn before finally closing this: Just though if we should add another extlink_update_8104() (+1) update hook to ensure it runs and remove the wrong extlink_additional_link_settings variables potentially set by extlink_update_8103()?

I merged the MR as hotfix!

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented

That might be a good follow-up. In my case, I just modified my config/extlink.settings.yml manually. But many won't do that and expect a more scripted solution.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Fixed » Needs work

Ok I'm setting this back to NW for @LRWebks to implement.

smustgrave’s picture

smustgrave commented

Should have time next week to make an update hook

lrwebks’s picture

lrwebks commented
Assigned: Unassigned » lrwebks

I'm on it right now!

lrwebks opened merge request !39

lrwebks’s picture

lrwebks commented
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Thanks for the fix @lrwebks!

  • anybody committed d8a4acaa on 2.0.x authored by lrwebks 
    Issue #3467662 by heddn, lrwebks, anybody: extlink_update_8103 for...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.