Drupal 11 compatibility

Hello,

I have tested MR !5 and it's applied successfully. I've also checked that into Drupal 11 and it's working as expected as well.

Same here, adding https://git.drupalcode.org/project/classy/-/merge_requests/5.patch to my composer.json makes upgrade_status module happy ! And it works well with my theme.

Attaching the MR5 patch

Tried both patches just in case there was a difference:
https://www.drupal.org/project/classy/issues/3461089#comment-15720455
https://www.drupal.org/project/classy/issues/3461089#comment-15743743

but both gave the same result in upgrade_status 4.3.5: classy: 1263 warnings found.
They are all depreciation notices, nearly all of the first one in the list:

1. vendor\symfony\deprecation-contracts\function.php 25 Since twig/twig 3.12: Getting node "filter" on a "Twig\Node\Expression\FilterExpression" class is deprecated
2. dropbutton-wrapper.html.twig 13 Since twig/twig 3.12: Twig Filter "spaceless" is deprecated. See https://drupal.org/node/3071078.

link-formatter-link-separate.html.twig 15 Since twig/twig 3.12: Twig Filter "spaceless" is deprecated. See https://drupal.org/node/3071078.

3. select.html.twig 13 Since twig/twig 3.12: Twig Filter "spaceless" is deprecated. See https://drupal.org/node/3071078.
4. toolbar.html.twig 30 Since twig/twig 3.12: Twig Filter "spaceless" is deprecated. See https://drupal.org/node/3071078.

On php 8.3.11 & drupal 10.3.5

After I upgraded to Drupal 10.3.6 all of the many "Getting node "filter" on a "Twig\Node\Expression\FilterExpression" class is deprecated" went away. Left were only the "spaceless" warnings. I tried to get rid of them though a combination of simply putting short passages onto one single line and in some cases I used "whitespace-control". After that all warnings were gone.

Please review the attached patch. I am not a twig expert and I might have screwed it up completely. Also, the last time I rolled a patch was probably more than a decade ago... :D

PHP 8.3.12
Drupal 10.3.6

Is there anything I can do to move this forward?

Tested successfully as a parent theme on 10.4.0

At some point I did get some stack traces re: stable, so I did end up installing that theme and a patch for this issue (https://www.drupal.org/project/drupal/issues/3478628) which isn't strictly related to this issue but it might help out folks with old themes so I thought I'd mention it

Hi ,
I tested this theme in both Drupal10 and drupal11 its working as expected I am requesting you to please release the stable version for Drupal 11. upgrade status also showing its compatible for Drupal11.

I test MR!5 on Drupal 11 with a custom theme that uses it as base theme. It works fine.
Upgrade status shows some errors to be fixed manually 'Since twig/twig 3.12: Twig Filter "spaceless" is deprecated. See https://drupal.org/node/3071078.' Patch #7 fixes this problem, but needs to be reviewed.

I move this issue to "Needs review"

patch #7 works for me

Added patch #7 to MR!5 , please review. phpunit test fails because theme name in this issue is classy-3461089 and not classy

I applied MR #5 and after running the upgrade status module scan is showed the module as Drupal 11 compatible.

I have also tested the patch could we get this merged?

tested and can cofirm it's ok.
Can we get a merge please?

I applied the initial commit from MR!5 and that worked fine for my use-case on a simple Drupal 11 site.
Spaceless isn't gone in Drupal 11 afaik, it's merely deprecated, so it's probably optional if the maintainers want to commit that bit or not.

Tested MR!5 on a Drupal 10.3.14 site. Everything seems to be working fine.

Tested MR!5 on a Drupal 11.1.5 site with the same results - everything seems to be working.

I made the patch file with the latest changes in the merge request

@bnjmnm, @davidhernandez, @lauriii : Please release a new tagged version which is Drupal 11 compatible

Hello,

I managed to build my Drupal project in Drupal 11.1.5 from my Drupal 10.4.5 version. My theme uses Classy as the base theme, but despite the patch, at each composer update, I get the error

Problem 1
- Root composer.json requires drupal/classy == 1.0.2.0 -> satisfiable by drupal/classy[1.0.2].
- drupal/classy 1.0.2 requires drupal/core ^9 || ^10 -> found drupal/core[9.0.0-alpha1, ..., 9.5.x-dev, 10.0.0-alpha1, ..., 10.5.x-dev] but these were not loaded, likely because it conflicts with another require.

This is normal behavior. The patch does not update metadata in composer or packigist, which composer update uses.

As a result, Classy will not be compatible with Drupal 11 until the patch is integrated into the module ?

@dark05 I think you have to take a look at https://github.com/mglaman/composer-drupal-lenient/

Thanks @smustgrave for the merges & release ! <3