Problem/Motivation
Drupal > 10.3.0 uses UserAuthenticationInterface to replace UserAuthInterface. See #3427298: Deprecate UserAuthInterface.
With Drupal 11 it will be deprecated and starting from Drupal 10.3.0 it starts to make trouble:
#3456923: Error: Call to undefined method Drupal\mail_login\AuthDecorator::authenticateAccount() with Drupal 10.3.0
This needs to be replaced (probably in a 4.x branch) like in email_registration: https://www.drupal.org/project/email_registration/issues/3456461
4.x should then require Drupal 10.3.0 and upwards, while 3.x should end with 10.2.x.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 3456996.patch | 5.04 KB | rajdip_755 |
Issue fork mail_login-3456996
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
anybodyComment #3
prabuela commentedComment #4
john.karam commentedThe hotfix lets users login to the website with the email, however the rest api endpoint fails with the error:
Symfony\Component\HttpKernel\Exception\BadRequestHttpException: Sorry, unrecognized username or password. στην Drupal\user\Controller\UserAuthenticationController->login() (Line 239 από /srv/websites/mysite/web/core/modules/user/src/Controller/UserAuthenticationController.php).
Could you please help?
Comment #5
phjouI do experience the same issue when using the rest api endpoint.
Comment #6
prabuela commentedComment #7
anybody@john.karam I can't confirm #4 in our case with the hotfix. It seems to work. Could you dive deeper?
Comment #8
rajdip_755I'm using a drupal 11 setup and try to use UserAuthenticationInterface instead of UserAuthInterface and created the following patch for the fixes. I have changed the authentication workflow little bit to use the UserAuthenticationInterface.
Please review the patch. If it's working fine we can convert it to MR.
Thanks !
Comment #9
rajdip_755Comment #10
anybodyComment #12
mqannehI created a new dev branch 4.0.x for this. I couldn't reproduce the issue in #4 so I'll keep this opened for review by the community.
Comment #14
mqannehComment #15
klemendev commentedIs this why mail login 3.1 does not work with Drupal 10.3.x and forces downgrade to 10.2.x when installing latest update?
Comment #16
klemendev commentedOpened new issue: https://www.drupal.org/project/mail_login/issues/3462188
Comment #17
mqanneh@KlemenDEV
Added v4.0.0 for Drupal >=10.3
Added v3.0.1 for Drupal <10.3
and updated the module page information.
Comment #18
klemendev commentedThanks!
Comment #19
vipin.j commentedYes, the version 4.0.1 conflicts with Commerce Core: 2.39 and failed the drush site installation.
Comment #20
zaporylieComment #21
openmode commentedDrupal core 10.3.1, Commerce Core 8.x-2.38, Mail Login 4.0.2
In this configuration in not possible to modify the checkout-flows of commerce.
/admin/commerce/config/checkout-flows/manage/
Comment #22
zaporylie@openmode Mail Login 4.0.3 was released yesterday and should address that issue.
Comment #23
mqanneh