Problem/Motivation

Drupal > 10.3.0 uses UserAuthenticationInterface to replace UserAuthInterface. See #3427298: Deprecate UserAuthInterface.

With Drupal 11 it will be deprecated and starting from Drupal 10.3.0 it starts to make trouble:
#3456923: Error: Call to undefined method Drupal\mail_login\AuthDecorator::authenticateAccount() with Drupal 10.3.0

This needs to be replaced (probably in a 4.x branch) like in email_registration: https://www.drupal.org/project/email_registration/issues/3456461

4.x should then require Drupal 10.3.0 and upwards, while 3.x should end with 10.2.x.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 3456996.patch5.04 KBrajdip_755

Issue fork mail_login-3456996

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

  • 3456996- Comparecompare

Comments

Anybody created an issue. See original summary.

anybody’s picture

Issue summary: View changes
prabuela’s picture

Assigned: Unassigned » prabuela
john.karam’s picture

The hotfix lets users login to the website with the email, however the rest api endpoint fails with the error:

Symfony\Component\HttpKernel\Exception\BadRequestHttpException: Sorry, unrecognized username or password. στην Drupal\user\Controller\UserAuthenticationController->login() (Line 239 από /srv/websites/mysite/web/core/modules/user/src/Controller/UserAuthenticationController.php).

Could you please help?

phjou’s picture

I do experience the same issue when using the rest api endpoint.

prabuela’s picture

Assigned: prabuela » Unassigned
anybody’s picture

@john.karam I can't confirm #4 in our case with the hotfix. It seems to work. Could you dive deeper?

rajdip_755’s picture

StatusFileSize
new5.04 KB

I'm using a drupal 11 setup and try to use UserAuthenticationInterface instead of UserAuthInterface and created the following patch for the fixes. I have changed the authentication workflow little bit to use the UserAuthenticationInterface.

Please review the patch. If it's working fine we can convert it to MR.

Thanks !

rajdip_755’s picture

Status: Active » Needs review
anybody’s picture

Version: 3.0.0 » 3.0.x-dev

  • mqanneh committed 6f4d28bd on 3.0.x
    Issue #3456996 by rajdip_755: Use UserAuthenticationInterface instead of...
mqanneh’s picture

I created a new dev branch 4.0.x for this. I couldn't reproduce the issue in #4 so I'll keep this opened for review by the community.

  • mqanneh committed 9d7faed4 on 4.0.x
    Issue #3456996 by PrabuEla, rajdip_755, Anybody, john.karam, phjou,...
mqanneh’s picture

Version: 3.0.x-dev » 4.0.x-dev
klemendev’s picture

Is this why mail login 3.1 does not work with Drupal 10.3.x and forces downgrade to 10.2.x when installing latest update?

klemendev’s picture

mqanneh’s picture

@KlemenDEV
Added v4.0.0 for Drupal >=10.3
Added v3.0.1 for Drupal <10.3
and updated the module page information.

klemendev’s picture

Thanks!

vipin.j’s picture

Yes, the version 4.0.1 conflicts with Commerce Core: 2.39 and failed the drush site installation.

zaporylie’s picture

Status: Needs review » Fixed
openmode’s picture

Drupal core 10.3.1, Commerce Core 8.x-2.38, Mail Login 4.0.2

In this configuration in not possible to modify the checkout-flows of commerce.

/admin/commerce/config/checkout-flows/manage/

zaporylie’s picture

@openmode Mail Login 4.0.3 was released yesterday and should address that issue.

mqanneh’s picture

Status: Fixed » Closed (fixed)