Problem/Motivation

In #3413017: Using a translatable string as a category for field type is deprecated in drupal:10.2, a new field type category was added for the Address field. We should also add an icon to replace the default one:

Screenshot

CommentFileSizeAuthor
#5 Screenshot 2025-01-10 at 14.32.10.png107.4 KBdunx
#2 address-icon-3454405-02.patch2.21 KBnilesh.addweb
CleanShot 2024-06-13 at 14.45.45.png7.67 KBdieterholvoet

Issue fork address-3454405

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DieterHolvoet created an issue. See original summary.

nilesh.addweb’s picture

nilesh.addweb commented
Status: Active » Needs review
StatusFileSize
new address-icon-3454405-02.patch2.21 KB

Hi, I’ve added a patch to add the icon for the address field type category. Please review it.

dunx made their first commit to this issue’s fork.

dunx’s picture

dunx commented

I raised this issue against Drupal CMS as the Address field is one of only two field types that does not have its own icon within the new field UI. As this impacts the initial Drupal CMS user experience it would be great to have this fixed before the launch of Drupal CMS in 5 days :)

No icons

I will try and test this patch today.

dunx’s picture

dunx commented
StatusFileSize
new Screenshot 2025-01-10 at 14.32.10.png107.4 KB

Tested and successful.

  1. Installed current D11.
  2. Added the address module composer require drupal/address
  3. Installed this patch with composer.
  4. Visit /admin/structure/types/manage/article/fields/add-field

The address field now has a suitable icon.

New address icon

dunx’s picture

dunx commented
Status: Needs review » Reviewed & tested by the community
bojanz’s picture

bojanz commented

Thanks for testing! Making a few tweaks and committing.

  • bojanz committed 9cbce324 on 2.0.x 
    Issue #3454405 by dunx, nilesh.addweb, bojanz: Add an icon for the...

  • bojanz committed 7274cd46 on 2.x 
    Issue #3454405 by dunx, nilesh.addweb, bojanz: Add an icon for the...

  • bojanz committed be0bba0a on 2.1.x 
    Issue #3454405 by dunx, nilesh.addweb, bojanz: Add an icon for the...
bojanz’s picture

bojanz commented
Status: Reviewed & tested by the community » Fixed

Tagging 2.0.3, just in time for the Drupal CMS release.

dunx’s picture

dunx commented

Nice @bojanz and thanks for the timely update for Drupal CMS 1.0 :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.