On Drupal 10.3-beta1, I've this error on a node edit page with a CKEditor and OpenAI enabled:

TypeError: e.Model is not a constructor
    init http://drupal.xxx.loc/modules/contrib/openai/modules/openai_ckeditor/js/build/openai.js?sei2i8:1
    create http://drupal.xxx.loc/core/assets/vendor/ckeditor5/ckeditor5-dll/ckeditor5-dll.js?v=41.3.1:5
CommentFileSizeAuthor
#8 openai-drupal_10_3-3452184-8.patch72.23 KBliam morland
#3 Screenshot 2024-06-24 at 2.23.42 PM.png41.54 KBjohnpicozzi

Issue fork openai-3452184

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lussoluca created an issue. See original summary.

lussoluca’s picture

lussoluca
he/him
Primary language Italian
Location Italy
commented
Issue summary: View changes
johnpicozzi’s picture

johnpicozzi
Primary language English
Location Providence, RI
commented
StatusFileSize
new Screenshot 2024-06-24 at 2.23.42 PM.png41.54 KB

I can confirm I also have this error with OpenAI CKEditor integration Module enabled. As soon as the module is disabled the CKEditor displays as expected. Prior to disabling the module the body filed on my content type would not display. See below screenshot

johnpicozzi’s picture

johnpicozzi
Primary language English
Location Providence, RI
commented
Title: Compatibility with Drupal 10.3 » OpenAI CKEditor integration compatibility issue with Drupal 10.3
Component: Code » OpenAI CKEditor
Priority: Normal » Major

Updating the title of this issue and moving priority to Major as it makes the body field unusable.

Liam Morland made their first commit to this issue’s fork.

Liam Morland opened merge request !93

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 1.0.0-beta5 » 1.0.x-dev
Status: Active » Needs review

The merge request has a fix, though this may cause problems with backward compatibility. This is a similar issue to #3452570: CKEditor 5 41.3.1 (Drupal 10.3 beta) breaking change; we may need to do something like the fix in this issue to resolve the backward compatibility problem.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
StatusFileSize
new openai-drupal_10_3-3452184-8.patch72.23 KB

Patch with current state of merge request.

johnpicozzi’s picture

johnpicozzi
Primary language English
Location Providence, RI
commented

@Liam Morland Looks like the MR doesn't pass all it's tests. I'll be reviewing the patch to confirm it resolves the issue shortly.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

The only test warnings are coding standards and those also have warnings on the development branch.

johnpicozzi’s picture

johnpicozzi
Primary language English
Location Providence, RI
commented

@Liam Morland I'm seeing that now. I have tested this locally and it works for me. RTBC +1

rajab natshah’s picture

rajab natshah
he/him
commented

The patch in #8 is working
Thank you, Liam

johnpicozzi’s picture

johnpicozzi
Primary language English
Location Providence, RI
commented
Status: Needs review » Reviewed & tested by the community

scott_euser made their first commit to this issue’s fork.

scott_euser’s picture

scott_euser commented
Status: Reviewed & tested by the community » Fixed

Thanks everyone! Booted up a fresh 10.3 to test with this branch and went through the process of configuring through to using some tools like summarise, etc within the editor and all working great. Thank you. Expect a new release shortly

scott_euser’s picture

scott_euser commented

Kevin make the release here: https://www.drupal.org/project/openai/releases/1.0.0-beta6

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.