Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 11.
Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.
The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated changes until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated changes.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.
If the issue is reopened, then new automated changes will be posted.
If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Using the merge request
- Review the merge request and test it.
- Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.
Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!
Providing feedback
If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | tablefield.2.x-dev.rector.patch | 1.33 KB | project update bot |
| #4 | interdiff-last-bot.6942740.txt | 653 bytes | project update bot |
| #2 | tablefield.2.x-dev.rector.patch | 364 bytes | project update bot |
Issue fork tablefield-3451341
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the
info.ymlfile for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #4
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the
info.ymlfile for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #5
d.fisher commentedThis looks pretty straight forward. Can this be merged so we can start preparing for D11 support?
Comment #6
d.fisher commentedHi again. Sorry to double post but Drupal 11 is out now and we're looking at the upgrade path for many sites that use this module. Is there a timeframe for getting this patch into a stable release for the module?
Comment #7
f0ns commentedI just tested the patch in comment #4 and everything seems to work fine.
I was wondering if this can get merged in a new release?
For now I'll use the patch as this is one of the modules that holds me from upgrading to Drupal 11.
Thank you!
Comment #8
d.fisher commentedPatch in #4 works for me too and equally this is preventing an upgrade to D11 where we'd prefer this to be in a stable release. Marking RTBC. Hope that's ok?
Comment #10
liam morlandI have put patch #4,
tablefield.2.x-dev.rector.patch, into the merge request.Comment #11
d.fisher commentedJust tested the latest MR as well and can confirm all working as expected for our use case!
Comment #12
w01f commentedVery interested in getting this module caught up with all recent code updates and D11 compatibility for a specific education site I maintain - any chance on getting final review and a release out? =)
Comment #13
f0ns commentedJust tested it again and looks good to go.
Comment #16
liam morlandMerged. Leaving open for more automated patches.
Comment #18
d.fisher commentedIs there going to be a 3.0.x tagged release for tablefield?
Comment #19
erutan commentedThere will be - there's currently one patch from the recent round of reviewing that is only in 3.0x because it breaks backwards compatibility with Drupal < 10.3 https://www.drupal.org/project/tablefield/issues/3472593. I'm going through some of the old needs review and RBTC patches to get them into 2.0.x before focus shifts to 3.0.x.
It wouldn't hurt to put up a beta 3.0x tag in the meantime though. Thoughts @liam?
Comment #20
liam morlandSure. Please make a 3.0.x development snapshot release first. Then, if you like, I'll make a beta.
Comment #21
erutan commentedDone. :)
Comment #22
liam morlandComment #23
ruslan piskarovLooks good too. We need a D11 release as soon as possible. Could the author of the module create the 3.0.0 release?
Comment #24
liam morlandtablefield 3.0.0-beta1