Closed (fixed)
Project:
Experience Builder
Component:
Page builder
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
28 May 2024 at 08:57 UTC
Updated:
14 Jun 2024 at 13:59 UTC
Jump to comment: Most recent
Problem/Motivation
Currently HTTP requests are being mocked in the UI components with miragejs.
Migrate JS has only a 0.1 release and has around 280k downloads a week.
MSW has a 2.3 release and around 2.8m downloads a week.
Steps to reproduce
Proposed resolution
Switch to msw for tests and mocking
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork experience_builder-3450302
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
larowlanComment #3
wim leersI doubt @jessebaker feels strongly about this. I'd definitely welcome an MR, but let's hear if he has a reason to not do this.
Comment #5
larowlanThere's an MR there for consideration
Comment #6
larowlanThis is also setup for use in tests so we can start tests - #3450306: Add component tests using testing-library
Comment #7
jessebaker commentedFully in favour - miragejs was only intended as a super quick temporary solution so that I could work on the front end completely isolated from any backend requirements (and so I could try out a shiny new thing!).
I've approved your MR - it looks like a more robust and less temporary solution for tests etc.
Comment #8
wim leersNow just needs @bnjmnm's approval.
Comment #9
wim leersReady for Ben to sign off & merge :)
Comment #10
wim leers🚢