Steps to reproduce
After enabling this module when we try to submit a contact form of webform it throws an error.
Fatal error: Type of Drupal\webform\Plugin\DevelGenerate\WebformSubmissionDevelGenerate::$entityTypeManager must be Drupal\Core\Entity\EntityTypeManagerInterface (as in class Drupal\devel_generate\DevelGenerateBase)
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | 3447608-15.patch | 30.81 KB | diederik.beirnaert |
| webform.png | 16.01 KB | aman_lnwebworks |
Issue fork webform-3447608
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
aaron.ferris commentedAdded a MR, do we need to do something with respect to the Devel version?
This change seems to be in ^5.2.0
Comment #5
aaron.ferris commentedComment #6
cilefen commentedDid you test on 6.2.x or 6.2.2?
I am setting this to major because Devel Is not required on production sites.
Comment #7
pilox033873 commentedThe issue is triggered when I set up emails/handlers in the web form
Comment #8
cilefen commentedIs this a duplicate of #3435903: Fix incompatibility with devel ^5.2?
Comment #9
alberto56 commentedRelated to #3155654: [Drupal 9.x] Declaration of Drupal\webform\Plugin\DevelGenerate\WebformSubmissionDevelGenerate::validateDrushParams($args) must be compatible with Drupal\devel_generate\DevelGenerateBaseInterface::validateDrushParams(array $args, array $options = Array) and #3499830: Move DevelGenerate plugin to a new webform_devel_generate module within this project
Comment #10
liam morlandDoes this problem still exist on 6.3.x? It looks like this was fixed in #3465838: Drupal 11 compatibility fixes for webform, commit 4624076, which is in 6.3.0-alpha1.
The fix is probably just removing
protected $entityTypeManager;insrc/Plugin/DevelGenerate/WebformSubmissionDevelGenerate.php. That way, it uses the declaration of this property from its parent class.Comment #11
oumayma elhaddam commentedfor me i uninstalled devel and did :
drush pmu devel_generateand it fixed the issue
Comment #12
liam morlandPlease confirm that the problem does not exist in 6.3.x.
I have removed the property. I expect that will fix it. Please test.
Comment #13
liquidcms commentedI didnt see the error in the logs but Webform sending email was being broken by the Devel Generate module with Webform 6.2.9 and Devel 5.3.1.
With Webform 6.3.0-beta1 this is fixed.
Comment #14
liam morlandIs it fixed if you use 6.2.x with merge request !470?
Comment #15
diederik.beirnaert commentedThis worked for me for 6.2.9
Comment #16
liam morlandIs that different from merge request 470?
Comment #17
diederik.beirnaert commentedyes it is.
in MR 470 only the entityTypeManager got removed but that did not do the trick for me.
Comment #18
liam morlandCan you put your change into the merge request? It also needs to be re-based into 6.3.x.
Comment #19
liam morlandComment #20
joumCan confirm #15 applies on 6.2.9 and solves
Fatal error: Type of Drupal\webform\Plugin\DevelGenerate\WebformSubmissionDevelGenerate::$entityTypeManager must be Drupal\Core\Entity\EntityTypeManagerInterface (as in class Drupal\devel_generate\DevelGenerateBase) in /var/www/html/docroot/modules/contrib/webform/src/Plugin/DevelGenerate/WebformSubmissionDevelGenerate.php on line 30
on webform submission.
Comment #21
vitor faria commentedThis ticket should be moved to RTBC. Reasons being:
Comment #22
liam morlandThis change was made in 6.3.x in commit 4624076 for #3465838: Drupal 11 compatibility fixes for webform.
Comment #24
liam morland