Steps to reproduce

After enabling this module when we try to submit a contact form of webform it throws an error.

Fatal error: Type of Drupal\webform\Plugin\DevelGenerate\WebformSubmissionDevelGenerate::$entityTypeManager must be Drupal\Core\Entity\EntityTypeManagerInterface (as in class Drupal\devel_generate\DevelGenerateBase)

CommentFileSizeAuthor
#15 3447608-15.patch30.81 KBdiederik.beirnaert
webform.png16.01 KBaman_lnwebworks

Issue fork webform-3447608

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

aman_lnwebworks created an issue. See original summary.

aaron.ferris made their first commit to this issue’s fork.

aaron.ferris’s picture

Added a MR, do we need to do something with respect to the Devel version?

This change seems to be in ^5.2.0

aaron.ferris’s picture

Status: Active » Needs review
cilefen’s picture

Version: 6.2.2 » 6.2.x-dev
Priority: Critical » Major

Did you test on 6.2.x or 6.2.2?

I am setting this to major because Devel Is not required on production sites.

pilox033873’s picture

The issue is triggered when I set up emails/handlers in the web form

cilefen’s picture

Status: Needs review » Postponed (maintainer needs more info)
liam morland’s picture

Version: 6.2.x-dev » 6.3.x-dev

Does this problem still exist on 6.3.x? It looks like this was fixed in #3465838: Drupal 11 compatibility fixes for webform, commit 4624076, which is in 6.3.0-alpha1.

The fix is probably just removing protected $entityTypeManager; in src/Plugin/DevelGenerate/WebformSubmissionDevelGenerate.php. That way, it uses the declaration of this property from its parent class.

oumayma elhaddam’s picture

for me i uninstalled devel and did : drush pmu devel_generate
and it fixed the issue

liam morland’s picture

Version: 6.3.x-dev » 6.2.x-dev
Status: Postponed (maintainer needs more info) » Needs review

Please confirm that the problem does not exist in 6.3.x.

I have removed the property. I expect that will fix it. Please test.

liquidcms’s picture

I didnt see the error in the logs but Webform sending email was being broken by the Devel Generate module with Webform 6.2.9 and Devel 5.3.1.

With Webform 6.3.0-beta1 this is fixed.

liam morland’s picture

Is it fixed if you use 6.2.x with merge request !470?

diederik.beirnaert’s picture

StatusFileSize
new30.81 KB

This worked for me for 6.2.9

liam morland’s picture

Is that different from merge request 470?

diederik.beirnaert’s picture

yes it is.
in MR 470 only the entityTypeManager got removed but that did not do the trick for me.

liam morland’s picture

Version: 6.2.x-dev » 6.3.x-dev
Issue tags: +Needs reroll

Can you put your change into the merge request? It also needs to be re-based into 6.3.x.

liam morland’s picture

Status: Needs review » Needs work
joum’s picture

Can confirm #15 applies on 6.2.9 and solves

Fatal error: Type of Drupal\webform\Plugin\DevelGenerate\WebformSubmissionDevelGenerate::$entityTypeManager must be Drupal\Core\Entity\EntityTypeManagerInterface (as in class Drupal\devel_generate\DevelGenerateBase) in /var/www/html/docroot/modules/contrib/webform/src/Plugin/DevelGenerate/WebformSubmissionDevelGenerate.php on line 30

on webform submission.

vitor faria’s picture

This ticket should be moved to RTBC. Reasons being:

  • patch for 6.2.9 seems to have been tested and is working
  • patch does not need to be rebased as code is already present (or fixed) in version 6.3. I just tested it and #liquidcms also confirms it in comment #13
liam morland’s picture

Version: 6.3.x-dev » 6.2.x-dev

This change was made in 6.3.x in commit 4624076 for #3465838: Drupal 11 compatibility fixes for webform.

liam morland’s picture

Status: Needs work » Fixed
Issue tags: -Needs reroll

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.