Problem/motivation

Ckeditor5 link url form submit on enter keypress or non-autocomplete selection does not remove existing data-* attributes.

This is a problem when changing a link from one that should be linkit url converted to a link that should not.

example

Steps to reproduce

1. Create a link from an autocomplete suggestion by mouse clicking on it.
View source to see that data-* attributes were set.

2. Edit the link, change the link by typing in a new value such as "google.com" and keypress enter.
View source to see that the href is now "google.com" but data-* attributes for previous entity still exists.

CommentFileSizeAuthor
#9 3443845-remove-attributes-on-non-autocomplete-09.patch1.21 KBdrpldrp
#8 3443845-remove-attributes-on-non-autocomplete-08.patch1.27 KBdrpldrp
#7 3443845-remove-attributes-on-non-autocomplete.patch1.46 KBdrpldrp
#2 example.gif322.28 KBdrpldrp

Comments

drpldrp created an issue. See original summary.

drpldrp’s picture

drpldrp commented
StatusFileSize
new example.gif322.28 KB
drpldrp’s picture

drpldrp commented
Issue summary: View changes
drpldrp’s picture

drpldrp commented
Issue summary: View changes
drpldrp’s picture

drpldrp commented
Issue summary: View changes
drpldrp’s picture

drpldrp commented
Issue summary: View changes
drpldrp’s picture

drpldrp commented
Issue summary: View changes
StatusFileSize
new 3443845-remove-attributes-on-non-autocomplete.patch1.46 KB
drpldrp’s picture

drpldrp commented
StatusFileSize
new 3443845-remove-attributes-on-non-autocomplete-08.patch1.27 KB
drpldrp’s picture

drpldrp commented
StatusFileSize
new 3443845-remove-attributes-on-non-autocomplete-09.patch1.21 KB

This one might be the cleanest but relies on addEventListener('input'.

drpldrp’s picture

drpldrp commented
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Title: link url keypress enter does not remove attributes » When [Enter] key is used to replace a link, the previous link's attributes are not removed

  • mark_fullmer committed 803fd009 on 6.1.x 
    Issue #3443845 by drpldrp, mark_fullmer: When [Enter] key is used to...
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Active » Fixed

I was able to reproduce the problem, verified the fix, and reviewed the logic of the code change. Thanks for reporting and for the fix!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.