Problem/Motivation
- https://github.com/ckeditor/ckeditor5/releases/tag/v41.3.0
- https://github.com/ckeditor/ckeditor5/releases/tag/v41.3.1
41.3 brings multi-level lists and improved keyboard navigation!
Steps to reproduce
Proposed resolution
Update to CKEditor 5 v41.3.1 on both 10.3.x and 11.x.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3443567-nr-bot.txt | 90 bytes | needs-review-queue-bot |
Issue fork drupal-3443567
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3443567-update-ckeditor-5-11.x
changes, plain diff MR !7743
- 3443567-10.3.x
changes, plain diff MR !7744
Comments
Comment #4
longwaveComment #5
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #6
longwaveComment #7
longwave10.3.x MR has the yarn 4 files in it.
Comment #8
longwaveFixed #7, also backported the .gitignore from 11.x to prevent this happening again, this isn't the first time I've done this by mistake when switching branches.
Comment #9
smustgrave commentedTested this out on a standard install on 11.x
Enabled Media library to test that button.
Updated text format with media library button, image upload, table, lists
Created a page testing all the buttons behave as expected.
Comment #10
catch11.x needs a rebase (unless I'm very confused).
Comment #11
wim leersYay, tests are passing — no subtle BC breaks this time 🥳
Per https://github.com/ckeditor/ckeditor5/releases/tag/v41.3.0, 41.3 brings multi-level lists (in a separate plugin which we're not offering, and a new/separate toolbar item) and improved keyboard navigation (across all of CKEditor 5, so we are getting that!).
Review
Nit:
package.jsonlists41.3.0, not41.3.1.Comment #13
adwivedi008 commentedRebased '3443567-update-ckeditor-5-11.x' branch with 11.x
Comment #14
longwaveBoth MRs apply for me.
Comment #15
salmonek commentedWe'll have it covered in the CKEditor 5 Premium Features module.
Comment #16
catchpackage.json is still listing
41.3.0per #11.Comment #17
longwaveIt's using the tilde syntax so IMHO it doesn't really matter, but updated anyway.
Comment #20
catchOh good point, should've spotted that but thanks for updating anyway.
Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!
Comment #23
longwaveComment #24
wim leers#17: yep, that's why it was a nit :)
Thanks for making this happen, @longwave! 🙏