Problem/Motivation

41.3 brings multi-level lists and improved keyboard navigation!

Steps to reproduce

Proposed resolution

Update to CKEditor 5 v41.3.1 on both 10.3.x and 11.x.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 3443567-nr-bot.txt90 bytesneeds-review-queue-bot

Issue fork drupal-3443567

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

longwave created an issue. See original summary.

longwave’s picture

Status: Active » Needs review
needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new90 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

longwave’s picture

Status: Needs work » Needs review
Issue tags: +no-needs-review-bot
longwave’s picture

Status: Needs review » Needs work

10.3.x MR has the yarn 4 files in it.

longwave’s picture

Status: Needs work » Needs review

Fixed #7, also backported the .gitignore from 11.x to prevent this happening again, this isn't the first time I've done this by mistake when switching branches.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Tested this out on a standard install on 11.x
Enabled Media library to test that button.
Updated text format with media library button, image upload, table, lists
Created a page testing all the buttons behave as expected.

catch’s picture

Status: Reviewed & tested by the community » Needs work

11.x needs a rebase (unless I'm very confused).

wim leers’s picture

Issue summary: View changes
Issue tags: +Accessibility, +JavaScript
Related issues: +#3424644: Update CKEditor 5 to 41.2.0

Yay, tests are passing — no subtle BC breaks this time 🥳

Per https://github.com/ckeditor/ckeditor5/releases/tag/v41.3.0, 41.3 brings multi-level lists (in a separate plugin which we're not offering, and a new/separate toolbar item) and improved keyboard navigation (across all of CKEditor 5, so we are getting that!).

Review

Nit: package.json lists 41.3.0, not 41.3.1.

adwivedi008 made their first commit to this issue’s fork.

adwivedi008’s picture

Issue tags: -JavaScript +JavaScript

Rebased '3443567-update-ckeditor-5-11.x' branch with 11.x

longwave’s picture

Status: Needs work » Reviewed & tested by the community

Both MRs apply for me.

salmonek’s picture

41.3 brings multi-level lists (in a separate plugin which we're not offering,

We'll have it covered in the CKEditor 5 Premium Features module.

catch’s picture

Status: Reviewed & tested by the community » Needs work

package.json is still listing 41.3.0 per #11.

longwave’s picture

Status: Needs work » Reviewed & tested by the community

It's using the tilde syntax so IMHO it doesn't really matter, but updated anyway.

  • catch committed 8e2de62d on 11.x
    Issue #3443567 by longwave: Update CKEditor 5 to 41.3.1
    

  • catch committed 3f6bec74 on 10.3.x
    Issue #3443567 by longwave: Update CKEditor 5 to 41.3.1
    
catch’s picture

Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Oh good point, should've spotted that but thanks for updating anyway.

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

longwave’s picture

wim leers’s picture

#17: yep, that's why it was a nit :)

Thanks for making this happen, @longwave! 🙏

  • catch committed 8e2de62d on 11.0.x
    Issue #3443567 by longwave: Update CKEditor 5 to 41.3.1
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.