Undefined array key 2 in Drupal\easy_breadcrumb\TitleResolver->getTitle() (line 82 of modules/contrib/easy_breadcrumb/src/TitleResolver.php).
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | easy_breadcrumb-3435864.patch | 780 bytes | abhishek_gupta1 |
Issue fork easy_breadcrumb-3435864
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
vinodhinisureshbabu commentedComment #3
abhishek_gupta1 commentedfixed the issue and please review the patch once.
Comment #4
greg boggsThanks for the fix. Generally, we use array_key_exists to check to see if the key exists.
Also, please open merge requests and not patches for code you want to include.
Comment #5
greg boggsComment #6
abhishek_gupta1 commentedComment #9
greg boggsThe code looks perfect! I'd merge it, but it looks like the patch file is also in the MR, and we don't want the patch file to end up in the final module.
Comment #10
abhishek_gupta1 commented@Greg Boggs, yes by mistake patch file is uploaded. now check the new MR.
Comment #11
abhishek_gupta1 commentedComment #12
rollins commented@Greg Boggs, maybe better to have one commit for this with better descriptions, what do you think?
I do not think that ‘fix the issue’ and ‘Removed patch file’ are good commit names for merging
Comment #13
spuky commentedlets wait for 3415146 the try catch in there should fix the warning if not the merge request will need to be addapted to the changes there.
Comment #14
spuky commentedSetting to needs work please check if the problem still exists if yes we need an updated merge request.
Comment #17
samitk commentedComment #19
spuky commented