Hi, i am trying to make it work in comments but no way, maybe i miss something. Working perfect in all nodes.
Input formats is ok.

Thanks.

CommentFileSizeAuthor
#9 guitar_diagram.module.test8.69 KBtune5b
#5 guitar_filter.module.test1.57 KBtune5b
#5 guitar_diagram.module.test8.48 KBtune5b
#3 guitar_filter_comments_1.patch966 bytesdawehner

Comments

floretan’s picture

floretan commented

I can confirm the issue, but unfortunately it will take some time until I can work on that.

errement’s picture

errement commented

Thank you so much flobruit for responding. Take your time and maybe we have it fixed on the next release or a patch.

Cheers!
;)

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new guitar_filter_comments_1.patch966 bytes

here is a patch which adds this functionality

errement’s picture

errement commented
Status: Needs review » Needs work

@dereine,

It doesn't work for me!

I added your patch and run update, add a comment, but it shows [C major:x,3,2,0,1,0] instead of the chord diagram.

Am i missing something?

tune5b’s picture

tune5b commented
Assigned: Unassigned » tune5b
Status: Needs work » Patch (to be ported)
StatusFileSize
new guitar_diagram.module.test8.48 KB
new guitar_filter.module.test1.57 KB

please test this version.

errement’s picture

errement commented

Ha ha…

Thank you so much tune5b. I do confirm that it works nicely in comments ;)

Masahiko, i laughed because i saw that you registered today and member since only 1 hour 9 min. ;)
So you came to send us the solution, thank you so much, my students are very pleased to at last enter their answers via comments in chord diagrams instead of text.
Welcome to Drupal world!!!

floretan’s picture

floretan commented
Status: Patch (to be ported) » Fixed

This issue has been overdue for way too long and was really due to a flaw in the module (using hook_nodeapi() rather than correctly using hook_filter()). Thanks to everyone who participated.

I committed the fix to guitar_filter.module and created a new release.

However, the changes in guitar_diagram.modules are not related to this issue. I'm interested in suggestions on how the chord diagram rendering can be improved, but please open a new issue with an explanation of what you're trying to change.

tune5b’s picture

tune5b commented

> However, the changes in guitar_diagram.modules are not related to this issue.

yes.
and sorry.
It is surely another problem.

tune5b’s picture

tune5b commented
StatusFileSize
new guitar_diagram.module.test8.69 KB

> but please open a new issue with an explanation of what you're trying to change.

In fact, I am weak in English.
And I still do not understand a rule of the community of here.
Therefore the open a new issue seems to be still impossible for the time being.

Referentially I show a new design.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.