Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
I seem to have found some cases where the number of search results doesn't match the number displayed to the end user. This mucks up things like the pager.
The module schema specifies general_settings.results as the results value, so let's standardise on that.
Steps to reproduce
- Set general_settings.pagesize to 20
- Leave general_settings.results at 10
- Perform any search
Proposed resolution
Deprecate general_settings.pagesize and use general_settings.results for all searching and pagination operations.
Remaining tasks
Implement the change.
User interface changes
None.
API changes
None.
Data model changes
Ensure general_settings.pagesize is removed from the module entirely. Since it's not in the schema this should work out OK.
Issue fork funnelback-3435248
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
geoffreyr commentedComment #4
larowlanDo we need a post-update hook to convert over any config that is using the old (wrong) key?
Comment #5
geoffreyr commentedUpdated MR with a post-update hook, as well as a module schema file.
Comment #6
geoffreyr commented