Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 11.
Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.
The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated changes until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated changes.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.
If the issue is reopened, then new automated changes will be posted.
If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Using the merge request
- Review the merge request and test it.
- Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.
Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!
Providing feedback
If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
Issue fork paragraphs-3433816
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore these changes did not update the
info.ymlfile for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #4
naveenvalechaComment #6
jurgenhaasI've added a repository to an MR for the entity_reference_revisions module so that test for Drupal 11 can be performed.
Comment #8
berdirERR D11 support is merged, updated composer.json and made all other dependencies lenient, composer build completes now on next majors but tests die hard due to the https://git.drupalcode.org/project/paragraphs/-/jobs/1683168 EntityReferenceTestTrait. That means we won't be able to test on 10.1 or lower, so previous minor will break and will have to be removed I guess.
Comment #9
berdirComment #10
berdirOne of the kernel migration tests is causing an infinite recursion in discovery of migration plugins. No idea about this code...
See https://git.drupalcode.org/project/paragraphs/-/merge_requests/102/diffs... and the referenced gist for the backtrace.
Comment #12
berdirThis is complex enough without phpcs/style changes. That's no in way related to Drupal 11 compatibility.
Comment #13
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.2, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.ymlfile for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
(removed tag to receive new patch)
These packages were used to generate the fixes:
Comment #15
jurgenhaasLooks like the bot broke the issue fork badly.
Comment #16
jurgenhaasAll commits after 25.5.2020 (i.e. 4 years ago) are suddenly gone in the
project-update-bot-onlybranch.Comment #17
berdirwe shouldn't have worked on that anyway, it did warn us, I'll reupload a local one, but there might also be a tagged backup.
(I would expect it would have just deleted our changes, not use a 4 year old one, but I guess it wanted to make a point or something ;))
Comment #18
jurgenhaasThat rather feels like a serious bug, especially since the bot also created a second MR on the same source and target combination. I didn't think that would even be possible with git.
Anyways, should we recover this by creating a second issue fork and re-build the changes that got lost? I'm asking because that would allow us to use that fork as a dependency for some scheduled Drupal 11 pipelines.
Comment #19
berdirThat was just a joke, I do hope the update bot is not sentient enough to punish us ;)
but yes, we should push the changes to a separate branch (in the same fork) maybe the one that got created by default already, and continue there. not expecting much more from the bot here anyway.
also, I had already extracted all the changes to fix 10.2/10.3 tests into #3451313: Drupal 10.2/10.3 test fixes, the blocker now is that migration stuff, that sounds like it might require a major rewrite.
Honestly tempted to just rip that all out and push it in a separate contrib project and let someone else maintain it.
Comment #21
jurgenhaasOK, I've started the branch
3433816-manual-drupal-11and created MR!114 as a starting point which contains the 2 proposed patches from the bot and declares Drupal 11 compatibility in the info file.Comment #28
berdirI recovered my local old branch with all the work that was done here, rebased on 8.x-1.x, pushed to https://git.drupalcode.org/project/paragraphs/-/merge_requests/115. Closed all other merge requests.
Comment #29
jurgenhaasThanks @Berdir let's hope that the bot doesn't override that branch next time it runs.
Comment #30
berdirThis isn't the same branch than the bot used, that one is named "project-update-bot-only", the one that has automated in the name is just named because it's the default branch created by drupal.org for the issue fork based on the issue title name. That one should not get overwritten.
Comment #31
jurgenhaasNot sure, we're on safe ground here. As you can see from https://www.drupal.org/project/paragraphs/issues/3433816#mr113-note320523 and https://www.drupal.org/project/paragraphs/issues/3433816#mr102-note320522 the bot committed to both open MRs back when it screwed up.
Comment #32
berdir@jurgenhaas: Both merge requests yes, but if you click on them or check the hidden branches on the issue summary you can see that both branches were opened for the same branch, project-update-bot-only. There's no guarantee with how bad the bot got confused here, but IMHO, using 3433816-automated-drupal-11 is as safe as any other branch on this fork.
Comment #33
bbralaAs per slack conversation with Berdir. Will hide the files for the bot so we can test updated logic to find the correct branch.
Comment #34
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.2, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.ymlfile for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #36
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.ymlfile for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #38
berdirThis now requires 10.2 and I removed a lot of BC layers, mostly in tests. The migrate workarounds are ugly, but I don't see another option without a major time investment. The migrate integration will most likely be removed if/when there is a 2.x of paragraphs.
The only failing tests are the IEF integration tests and I verified that they pass locally with the WIP patch from the IEF issue.
Merged.
Comment #39
andypost2 tests still fails in CI