Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3432303-2.patch29.93 KBchaitanyadessai

Issue fork saml_sp-3432303

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

chaitanyadessai created an issue. See original summary.

chaitanyadessai’s picture

chaitanyadessai commented
Assigned: chaitanyadessai » Unassigned
Status: Active » Needs review
StatusFileSize
new 3432303-2.patch29.93 KB

Please review patch
Fixed \Drupal calls and t() calls.

jrglasgow made their first commit to this issue’s fork.

jrglasgow opened merge request !50

  • jrglasgow committed 6cdd02d7 on 4.x 
    Issue #3432303: \Drupal calls should be avoided in classes, use...
rollins’s picture

rollins commented
Status: Needs review » Reviewed & tested by the community

Changes from MR look good, I think it can be merged

jrglasgow’s picture

jrglasgow commented
Status: Reviewed & tested by the community » Fixed

  • 48a6d5b6 committed on 4.x 
    #3432303 fixed and issue with the constructor

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.