Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 11.
Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.
The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated changes until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated changes.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.
If the issue is reopened, then new automated changes will be posted.
If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Using the merge request
- Review the merge request and test it.
- Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.
Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!
Providing feedback
If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | geofield.1.x-dev.rector.patch | 1.86 KB | project update bot |
| #15 | interdiff-last-bot.6912660.txt | 1.26 KB | project update bot |
| #2 | geofield.8.x-1.57.rector.patch | 372 bytes | project update bot |
Issue fork geofield-3430742
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3430742-automated-drupal-11
changes, plain diff MR !31
- project-update-bot-only
changes, plain diff MR !29
Comments
Comment #2
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the
info.ymlfile for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #6
jonathan1055 commentedWould the maintainers of this module be OK if I used this automated MR to test a new feature request of Gitlab Templates? The feature will automatically test the project-update-bot-only branch against the Next Major core version (which is Drupal 11). Currently your tests at Drupal 10 pass, but the point of this automated issue is to test against D11. You could manually opt in to testing against D11 but the feature being developed in #3449621: Add rule for project-update-bot to test against next major will do this automatically for the merge request generated by the project update bot.
Comment #7
ankitv18 commentedThis module is having require-dev dependency on drupal/feeds module which is not compatible with D11 so commented out OPT_IN_TEST_NEXT_MAJOR as it is failing the composer pipeline.
Change in Kernel Test taken a reference from https://www.drupal.org/project/drupal/issues/3393099
Comment #8
jonathan1055 commentedOK. The phpunit tests for Next Major are allowed to fail anyway, it would just show that the gitlab_templates change is working. It would not affect the pipelines in other issues or the scheduled pipelines, it would just test at D11 for these specific automatic MRs, which is ideal in your scenario. But if you'd prefer, I will find another project to test with.
Comment #9
ankitv18 commentedHi @itamir MR!31 is ready for a review,
Warning in phpcs pipeline can be ignored as its a false positive and phpstan next minor deprecation warning is related to D12
Comment #12
deepakkm commentedVerified changes on local and working fine, hence RTBC
Comment #13
kim.pepperThanks for working on this. FYI this is blocking Search API Opensearch Drupal 11.x support. #3452579: Add Drupal 11.x support for Search API OpenSearch
Comment #14
itamair commentedHi @here!
and sorry if I couldn't sync and stay on track with this ... BUT I had other priorities.
I could see some improving commits till some days ago, even after this was tagged as RTBC.
I wouldn't really re-review and re-QA (further) all this, as I can see many strong Drupal devs on this.
Thus, are we sufficiently confident in merging this MR into the 8.x-1.x dev branch and deploy a new geofield 8.x-1.58 release, compatible with Drupal 11???
Can e take this as All Done @ankitv18??
Comment #15
project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the
info.ymlfile for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #16
ankitv18 commentedYes @itamir
Sorry actually I just considered the MR feedback didn't take a look on the issue status.
Please review the MR!31 and let me know any changes required.
Comment #18
itamair commentedOk. MR!31 merged into 8.x-1.x dev, will be part of next Geofield 8.x-1.58 release ...
Thanks a lot for the great Job!
Comment #19
orkutmuratyilmaz@itamair, thanks for the release:)