Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#11 3430157-10.patch1.98 KBalberto56
#9 3430157-d11-compat-fixed-static-analysis.patch6.52 KBflutterstack
#6 3430157-d11-compat.patch728 bytesflutterstack
#2 entity_delete_log.1.1.1.rector.patch430 bytesproject update bot

Issue fork entity_delete_log-3430157

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new entity_delete_log.1.1.1.rector.patch430 bytes

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #11-121090

This patch was created using these packages:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.7
  3. palantirnet/drupal-rector: 0.20.1

Project Update Bot opened merge request !7

flutterstack’s picture

flutterstack commented
Issue summary: View changes
Issue tags: -ProjectUpdateBotD11
flutterstack’s picture

flutterstack commented 
 vendor/bin/drupal-check web/modules/custom/entity_delete_log/ --memory-limit=-1
Deprecated: The drupal_root parameter is deprecated. Remove it from your configuration. Drupal Root is discovered automatically. in /var/www/html/vendor/mglaman/phpstan-drupal/src/Drupal/DrupalAutoloader.php on line 94
 4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------------------------- 
  Line   entity_delete_log.module                                             
 ------ --------------------------------------------------------------------- 
  73     Class User not found.                                                
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
 ------ --------------------------------------------------------------------- 


 [ERROR] Found 1 error                                                          

Thanks for using drupal-check!

Consider sponsoring the development of the maintainers which make drupal-check possible:

- phpstan (ondrejmirtes): https://github.com/sponsors/ondrejmirtes
- phpstan-deprecation-rules (ondrejmirtes)): https://github.com/sponsors/ondrejmirtes
- phpstan-drupal (mglaman)): https://github.com/sponsors/mglaman
- drupal-check (mglaman)): https://github.com/sponsors/mglaman
flutterstack’s picture

flutterstack commented
StatusFileSize
new 3430157-d11-compat.patch728 bytes

#2 works fine.

In #6 I have applied #2 patch and fixed #5 drupal-check issue also. kindly review merge.

flutterstack’s picture

flutterstack commented
Version: 1.1.1 » 1.x-dev
flutterstack’s picture

flutterstack commented

static analysis on entity_delete_log throws below errors.

# php vendor/bin/drupal-check -a web/modules/custom/entity_delete_log --memory-limit=-1 
Deprecated: The drupal_root parameter is deprecated. Remove it from your configuration. Drupal Root is discovered automatically. in /var/www/html/vendor/mglaman/phpstan-drupal/src/Drupal/DrupalAutoloader.php on line 94
 4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------------- 
  Line   entity_delete_log.install                                          
 ------ ------------------------------------------------------------------- 
  13     Function entity_delete_log_schema() has no return type specified.  
  87     Function entity_delete_log_update_9001() has no return type        
         specified.                                                         
 ------ ------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------- 
  Line   entity_delete_log.module                                               
 ------ ----------------------------------------------------------------------- 
  13     Function entity_delete_log_entity_predelete() has no return type       
         specified.                                                             
  43     Function entity_delete_log_entity_delete() has no return type          
         specified.                                                             
  144    Function _edl_get_configured_entity_types() has no return type         
         specified.                                                             
  152    Function _edl_get_failure_messages() has no return type specified.     
  152    Function _edl_get_failure_messages() has parameter $variables with no  
         type specified.                                                        
  175    Function _edl_log_entity_deletion() has no return type specified.      
  175    Function _edl_log_entity_deletion() has parameter $variables with no   
         type specified.                                                        
 ------ ----------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------- 
  Line   entity_delete_log.views.inc                                            
 ------ ----------------------------------------------------------------------- 
  11     Function entity_delete_log_views_data() has no return type specified.  
 ------ ----------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------- 
  Line   src/Form/EntityDeleteLogSettingsForm.php                                              
 ------ -------------------------------------------------------------------------------------- 
  58     Method                                                                                
         Drupal\entity_delete_log\Form\EntityDeleteLogSettingsForm::create()                   
         has no return type specified.                                                         
  76     Method                                                                                
         Drupal\entity_delete_log\Form\EntityDeleteLogSettingsForm::getEditableConfigNames()   
         return type has no value type specified in iterable type array.                       
         💡 See:                                                                               
            https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type  
  85     Method                                                                                
         Drupal\entity_delete_log\Form\EntityDeleteLogSettingsForm::buildForm()                
         has parameter $form with no value type specified in iterable type                     
         array.                                                                                
         💡 See:                                                                               
            https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type  
  85     Method                                                                                
         Drupal\entity_delete_log\Form\EntityDeleteLogSettingsForm::buildForm()                
         return type has no value type specified in iterable type array.                       
         💡 See:                                                                               
            https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type  
  126    Method                                                                                
         Drupal\entity_delete_log\Form\EntityDeleteLogSettingsForm::submitForm()               
         has no return type specified.                                                         
  126    Method                                                                                
         Drupal\entity_delete_log\Form\EntityDeleteLogSettingsForm::submitForm()               
         has parameter $form with no value type specified in iterable type                     
         array.                                                                                
         💡 See:                                                                               
            https://phpstan.org/blog/solving-phpstan-no-value-type-specified-in-iterable-type  
 ------ -------------------------------------------------------------------------------------- 

 [ERROR] Found 16 errors                                                        

Thanks for using drupal-check!

Consider sponsoring the development of the maintainers which make drupal-check possible:

- phpstan (ondrejmirtes): https://github.com/sponsors/ondrejmirtes
- phpstan-deprecation-rules (ondrejmirtes)): https://github.com/sponsors/ondrejmirtes
- phpstan-drupal (mglaman)): https://github.com/sponsors/mglaman
- drupal-check (mglaman)): https://github.com/sponsors/mglaman
flutterstack’s picture

flutterstack commented
StatusFileSize
new 3430157-d11-compat-fixed-static-analysis.patch6.52 KB

#9 fixed static analysis issues and now its compatible with d11. kindly review

  • alberto56 committed c7b56cd2 on 1.x 
    Issue #3430157 by project update bot, flutterstack, alberto56: Automated...
alberto56’s picture

alberto56 commented
Status: Needs review » Fixed
StatusFileSize
new 3430157-10.patch1.98 KB

I have added the enclosed patch. The differences with the patch at #9 are:

* Removed Drupal 9 support as Drupal is no longer active
* I am not adding comments or changing the function signatures of methods which derive from Drupal, thus conforming to Drupal standards.

I have also made a new release with this change, 1.2.0

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.