Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#6 Screenshot 2024-08-17 153848.png43.57 KBdqd
#4 cer.5.0.0-beta3.rector.patch407 bytesproject update bot
#4 interdiff-last-bot.6909858.txt793 bytesproject update bot
#2 cer.5.0.0-beta3.rector.patch541 bytesproject update bot

Issue fork cer-3428343

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new cer.5.0.0-beta3.rector.patch541 bytes

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #11-120024

This patch was created using these packages:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.7
  3. palantirnet/drupal-rector: 0.20.1

Project Update Bot opened merge request !15

project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6909858.txt793 bytes
new cer.5.0.0-beta3.rector.patch407 bytes

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #11-120835

This patch was created using these packages:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.7
  3. palantirnet/drupal-rector: 0.20.1
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Priority: Normal » Major
Issue summary: View changes

Could someone please review and test the MR?

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot 2024-08-17 153848.png43.57 KB 
$ wget https://git.drupalcode.org/project/cer/-/merge_requests/15.patch
--2024-08-17 15:29:50--  https://git.drupalcode.org/project/cer/-/merge_requests/15.patch
Resolving git.drupalcode.org (git.drupalcode.org)... 146.75.122.217
Connecting to git.drupalcode.org (git.drupalcode.org)|146.75.122.217|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/plain]
Saving to: '15.patch'
15.patch [ <=> ]  734  --.-KB/s    in 0s
2024-08-17 15:29:51 (10.9 MB/s) - '15.patch' saved [734]

web/modules/contrib/cer$ git apply -v 15.patch
Checking patch cer.info.yml...
Applied patch cer.info.yml cleanly.

@Anybody: Done. Tested, applied successfully on a Drupal 10.3 installation and run thru upgrade-status with green. Then copied/installed on a Drupal 11 test installation with no flaws from a quick glimpse by testing usage with a node article <> basic page "related" cross reference. Error logs clean. Works as expected. RTBC from here +1.

PS: Upcoming changes in Drupal core 11.1 and higher should be tracked since it will possibly change things for cer too in near future.

dqd opened merge request !18

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Reviewed & tested by the community » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

LGTM! Thanks!

w01f’s picture

w01f commented

Tested on a D11.0.5 site with a bunch of other modules - works well, no conflicts, no issues!

steinmb’s picture

steinmb commented

+1 to get a Drupal 11 version.

dpiet’s picture

dpiet commented

Also tested on a D11.0.5 site, it is OK for me,

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

Since this is only a .info.yml change I guess this can be committed and a new release can be tagged. This should make upgrading easier.

phily’s picture

phily
he/him
Primary language French
Location 🇪🇺🇫🇷 Paris, France
commented

Both MRs work for me using Drupal 11.1.1

grevil made their first commit to this issue’s fork.

grevil’s picture

grevil commented

Just a slight adjustment, everything else LGTM!

Thanks everyone! Tagging a new D11 compatible release. :)

grevil’s picture

grevil commented
Version: 5.0.0-beta3 » 5.x-dev
Status: Reviewed & tested by the community » Fixed

All green.

  • grevil committed 1e5b051d on 5.x authored by dqd 
    Resolve #3428343 "Automated drupal 11"

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.