Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#15 upgrade_status.4.x-dev.upgrade_status.post_rector.txt0 bytesproject update bot
#15 upgrade_status.4.x-dev.rector.patch1.77 KBproject update bot
#15 interdiff-last-bot.6939162.txt1.86 KBproject update bot
#14 upgrade_status.4.x-dev.upgrade_status.post_rector.txt0 bytesproject update bot
#14 upgrade_status.4.x-dev.rector.patch1.77 KBproject update bot
#14 interdiff-last-bot.6921813.txt1.2 KBproject update bot
#13 upgrade_status.4.x-dev.upgrade_status.post_rector.txt0 bytesproject update bot
#13 upgrade_status.4.x-dev.rector.patch1.77 KBproject update bot
#13 interdiff-last-bot.6905524.txt0 bytesproject update bot
#2 upgrade_status.4.1.0.rector.patch1.77 KBproject update bot

Issue fork upgrade_status-3425263

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new upgrade_status.4.1.0.rector.patch1.77 KB

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.19.2, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #11-109123

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.2.7
  2. palantirnet/drupal-rector: 0.19.2

Project Update Bot opened merge request !73

rishabjasrotia made their first commit to this issue’s fork.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes

The automated fixes are all in compatibility code, so they don't need fixing. We should improve the tool instructions around them. The @noRector was clearly not enough :) I have a hard time to find docs as to how to correctly use that though. It would be good to improve that so that automated tooling does not complain.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

@rishabjasrotia: we should also update the .gitlabci.yml file to test with Drupal 11 to make sure it actually works. That would at least involve updating that file itself but also a bunch of work on the tests probably, since the tests will start to fail given the lack of Drupal 12 compatible projects in the test set, so that will also need updating and also some test conditions.

rishabjasrotia’s picture

rishabjasrotia commented

Hello @gábor-hojtsy,
I manage to update the pipeline to include Drupal 11 for composer stage.
While we still need to see about D11 test cases.

Gábor Hojtsy changed the visibility of the branch 3425263-upgrade-status-drupal-11 to hidden.

Gábor Hojtsy changed the visibility of the branch 4.x to hidden.

Gábor Hojtsy opened merge request !74

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

@rishabjasrotia: thanks! the project-update-bot-only branch intentionally has that name. Please do not commit to that as it would cause problems for project update bot in the future. Please revert your commits on that branch. I integrated your changes on the other active branch (and removed the 4.x branch you accidentally started using as well).

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

I submitted this PR to DrupalPod to make it possible for anyone to try out this MR in Drupal 11 :) https://github.com/shaal/DrupalPod/pull/144

To try with that PR, one would need to use https://gitpod.io/new/#DP_PROJECT_NAME=upgrade_status,DP_ISSUE_FORK=upgr... (note my fork at the end).

When running Upgrade Status on Drupal 11 in that setup, I noticed the fails are related to what seems to be things outside Upgrade Status(?)

gitpod /workspace/DrupalPod (codespace-legendary-acorn-4gppv6gxv3qqj6) $ ddev phpunit --filter UpgradeStatusAccessTest
PHPUnit 9.6.17 by Sebastian Bergmann and contributors.

Testing 
E.                                                                  2 / 2 (100%)

Time: 00:05.803, Memory: 142.00 MB

There was 1 error:

1) Drupal\Tests\upgrade_status\Functional\UpgradeStatusAccessTest::testDeprecationDashboardAccessUnprivileged
Exception: Deprecated function: Return type of Drupal\Component\Annotation\Doctrine\StaticReflectionClass::getStaticProperties(): ?array should either be compatible with ReflectionClass::getStaticProperties(): array, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
Drupal\Core\Render\ElementInfoManager->Drupal\Core\Render\{closure}()() (Line: 131)

/var/www/html/web/core/lib/Drupal/Core/Test/HttpClientMiddleware/TestHttpClientMiddleware.php:55
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:209
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:158
/var/www/html/vendor/guzzlehttp/promises/src/TaskQueue.php:52
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:251
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:227
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:272
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:229
/var/www/html/vendor/guzzlehttp/promises/src/Promise.php:69
/var/www/html/vendor/guzzlehttp/guzzle/src/Client.php:189
/var/www/html/web/core/tests/Drupal/Tests/DrupalTestBrowser.php:139
/var/www/html/vendor/symfony/browser-kit/AbstractBrowser.php:385
/var/www/html/vendor/behat/mink-browserkit-driver/src/BrowserKitDriver.php:122
/var/www/html/vendor/behat/mink/src/Session.php:175
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:284
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:254
/var/www/html/web/core/tests/Drupal/Tests/BrowserTestBase.php:373
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

ERRORS!
Tests: 2, Assertions: 9, Errors: 1.

HTML output was generated
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusAccessTest-1-46676110.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusAccessTest-2-46676110.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusAccessTest-3-46676110.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusAccessTest-4-46676110.html

Unsilenced deprecation notices (2)

Remaining self deprecation notices (32)

Remaining direct deprecation notices (10)

Remaining indirect deprecation notices (2)

Other deprecation notices (13)
Failed to run phpunit --filter UpgradeStatusAccessTest: exit status 2

-----------

This one has a real fail at least. 

gitpod /workspace/DrupalPod (codespace-legendary-acorn-4gppv6gxv3qqj6) $ ddev phpunit --filter UpgradeStatusUiTest
PHPUnit 9.6.17 by Sebastian Bergmann and contributors.

Testing 
.F.                                                                 3 / 3 (100%)

Time: 00:57.438, Memory: 142.00 MB

There was 1 failure:

1) Drupal\Tests\upgrade_status\Functional\UpgradeStatusUiTest::testUiAfterScan
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'No problems found'
+'1 problem'

/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121
/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/IsIdentical.php:79
/var/www/html/repos/upgrade_status/tests/src/Functional/UpgradeStatusUiTest.php:56
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

FAILURES!
Tests: 3, Assertions: 44, Failures: 1.

HTML output was generated
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-1-80846985.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-2-80846985.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-3-80846985.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-4-80846985.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-5-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-6-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-7-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-8-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-9-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-10-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-11-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-12-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-13-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-14-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-15-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-16-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-17-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-18-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-19-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-20-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-21-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-22-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-23-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-24-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-25-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-26-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-27-43256481.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-28-72289450.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-29-72289450.html
http://localhost:8080/sites/simpletest/browser_output/Drupal_Tests_upgrade_status_Functional_UpgradeStatusUiTest-30-72289450.html

Unsilenced deprecation notices (3)

Remaining self deprecation notices (68)

Remaining direct deprecation notices (10)

Remaining indirect deprecation notices (3)

Other deprecation notices (13)
Failed to run phpunit --filter UpgradeStatusUiTest: exit status 1

This later one is due to version specific logic. I'll review the version specific logic as we need some kind of strategy for this, especially if we want to support this on Drupal 9, 10 and 11 all at once and have tests that span all across.

project update bot’s picture

project update bot commented
Version: 4.1.0 » 4.x-dev
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new interdiff-last-bot.6905524.txt0 bytes
new upgrade_status.4.x-dev.rector.patch1.77 KB
new upgrade_status.4.x-dev.upgrade_status.post_rector.txt0 bytes

This comment was forced and has ignored the check if a change was already posted. This is only done when we want to update the issue without waiting for changes to happen.

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-136651

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.1.0
  2. mglaman/phpstan-drupal: 1.2.10
  3. palantirnet/drupal-rector: 0.20.1
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6921813.txt1.2 KB
new upgrade_status.4.x-dev.rector.patch1.77 KB
new upgrade_status.4.x-dev.upgrade_status.post_rector.txt0 bytes

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-177898

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.1
  2. mglaman/phpstan-drupal: 1.2.11
  3. palantirnet/drupal-rector: 0.20.1
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6939162.txt1.86 KB
new upgrade_status.4.x-dev.rector.patch1.77 KB
new upgrade_status.4.x-dev.upgrade_status.post_rector.txt0 bytes

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.2, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

Bot run #11-188815

These packages were used to generate the fixes:

  1. drupal/upgrade_status: 4.3.2
  2. mglaman/phpstan-drupal: 1.2.11
  3. palantirnet/drupal-rector: 0.20.2
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Automated Drupal 11 compatibility fixes for upgrade_status » Extensive Drupal 11 compatibility fixes, including new test coverage
Issue summary: View changes

Update title for correctness :)

  • Gábor Hojtsy committed 803d1945 on 4.x 
    Issue #3425263 by Gábor Hojtsy, Project Update Bot: Extensive Drupal 11...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.