Problem/Motivation

The adaptation from version 4 to version 5 so that the theme would be compatible with Drupal 10 has an error.
Because the initialisation of the source path is wrong, many other paths are wrong too.

Steps to reproduce

Proposed resolution

The line 98 in the file adaptivetheme/at_core/forms/color/color_submit.php should have this line:
$paths['source'] = \Drupal::service('extension.list.theme')->getPath($theme) . '/'; and not
$paths['source'] = \Drupal::service('extension.list.theme')->getPath($theme);

Remaining tasks

The solution is in the bug description.
Review, merge and release.

User interface changes

API changes

Data model changes

Issue fork adaptivetheme-3417049

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

EricVL created an issue. See original summary.

dineshkumarbollu made their first commit to this issue’s fork.

dineshkumarbollu opened merge request !6

dineshkumarbollu’s picture

dineshkumarbollu commented
Status: Active » Needs review

Hi @EricVL

created MR!6, Also checks other parts of the code no issues expect the adaptivetheme/at_core/forms/color/color_submit.php file, please review, Thanks

ericvl’s picture

ericvl
Primary language Dutch
Location Vichte, Belgium
commented
Status: Needs review » Reviewed & tested by the community
ericvl’s picture

ericvl
Primary language Dutch
Location Vichte, Belgium
commented
Version: 8.x-5.2 » 7.0.0

I believe, this merge request is still not merged into the latest release(s) although it is a major problem.
The original version was 5.2 when this isue was discovered. I changed the version to 7.
Is it possible that a maintainer looks into this issue please.
I"m using a local patch now to have the same result.
Thank you.

  • 636af633 committed on 8.x-6.x 
    Issue #3417049 by dineshkumarbollu, EricVL: Unable to add custom logo...
mattbloomfield’s picture

mattbloomfield commented

This will make into a new release today.

  • 670aeb0a committed on 7.0.x 
    Issue #3417049 by dineshkumarbollu, EricVL: Unable to add custom logo...
ericvl’s picture

ericvl
Primary language Dutch
Location Vichte, Belgium
commented

Thank you, Matt for the new 7.1 release.
Just 1 question: why don"t we see the 7.x releases on the Home page of this theme?
I do not have a problem with that because i"m using composer to get my packages. But if someone likes to check the latest version and download it there, he can't.
Greetings
Eric

PS the 2 issues that you solved in this latest release can be closed AFAIK.

ericvl’s picture

ericvl
Primary language Dutch
Location Vichte, Belgium
commented

Sorry Matt. Now I can see the reference to the 7.1 build.
I was too quick to respond.