Problem/Motivation

These words are all words prefixed with 'un'. Most occurrences are in tests but some are variable names.

Steps to reproduce

  1. unassigning
  2. unassigns
  3. unbans
  4. unbundleable
  5. unclickable
  6. uncollapsible
  7. ungenerated
  8. unparseable
  9. unpromoted
  10. unregisters
  11. unvalidated
  12. unwrapper

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 3412959-nr-bot.txt90 bytesneeds-review-queue-bot

Issue fork drupal-3412959

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !6051

quietone’s picture

quietone commented
Status: Active » Needs review

This is the first group of possibly hyphenated words that I have done, so setting this small set to Needs Review.

smustgrave’s picture

smustgrave commented

So I believe unvalidated is a correct word https://www.yourdictionary.com/unvalidated

quietone’s picture

quietone commented

You may believe that but cspell does not! :-)

And is that source using US English or something else?

The worn 'unvalidate' is not in the en_us dictionary used by cspell and neither is it at https://www.thefreedictionary.com/unvalidate, https://www.collinsdictionary.com/spellcheck/english?q=unvalidate, https://www.merriam-webster.com/dictionary/unvalidate. And three of them are definitely using US English.

quietone’s picture

quietone commented

Ah, the answer is to use 'non validated' as is used elsewhere in core, for example \Drupal\Core\Form\FormValidator::handleErrorsWithLimitedValidation. I just didn't think this through when I made the MR.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Ah good find. That makes more sense and sounds right when said out loud. Rest of word changes seem good

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3412959-nr-bot.txt90 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

quietone’s picture

quietone commented
Status: Needs work » Reviewed & tested by the community

It was a straightforward rebase so I restoring RTBC.

quietone’s picture

quietone commented
Issue tags: +cspell error
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Needs work

Added some suggestions/questions.

quietone’s picture

quietone commented
Status: Needs work » Needs review

Made the recommended changes and back to NR

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Feedback/follows up appear made.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » 10.2.x-dev
Status: Reviewed & tested by the community » Fixed

Cherry-picks cleanly to 10.2.x so backported there to keep things in sync as this only changes words in comments and tests.

Committed and pushed 2624df1b1c to 11.x and eb70d19029 to 10.2.x. Thanks!

  • longwave committed eb70d190 on 10.2.x 
    Issue #3412959 by quietone, smustgrave, longwave: Fix 12 'un' words

(...

  • longwave committed 2624df1b on 11.x 
    Issue #3412959 by quietone, smustgrave, longwave: Fix 12 'un' words

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone closed merge request !6051