Problem/Motivation

Quoted from parent issue:

Discovered at #2972224: Add .cspell.json to automate spellchecking in Drupal core, and pointed by @xjm in https://www.drupal.org/project/drupal/issues/3122088#comment-13628724

@xjm:

Should be hyphenated (un-assign, de-prioritize, re-render, etc.)

There's an interesting question of where to draw the line for these. Generally in English these prefixes are morphologically productive with a hyphen, and get de-hyphenated when the word is adopted into common usage. "Denormalize", "Unsanitized", "Uninstantiated" etc. are all obviously in common usage in programming. "Unsticky", "Unrevisionable", and the like are Drupal terminology, and I'm surprised that "unpublish" and friends aren't already in the main dictionary.

The parent issue tried to fix all words that should be hyphenated, but the patch for this was getting too big thus making it tricky to review. Also there were some debate about which words should be hyphenated, and which shouldn't. So they argued it would be better to separate the issue into 3 smaller ones (one each for words starting with 're', 'de' and 'un'). (see comment links bellow)

#3138768 #26.2 @xjm talks about the presave word and suggests to divide the issue.
#3138768 #31 @longwave agrees to divide the issue and says it's getting tricky to review.
#3138768 #36 @davidhernandez questions about if some words should be hyphenated.
#3138768 #38 @quietone agrees with @longwave about creating separated issues.

Proposed resolution

Check and decide as a group, with first-language speakers contributing, which of the following words are correct in Drupal and which should be hyphenated, then fix them as needed on the code.

  1. unban -> TODO: Look up context
  2. uncacheable -> un-cacheable
  3. uncategorized -> un-categorized (? – check if this is in the dictionary)
  4. ungroup -> un-group
  5. ungroupable -> un-groupable
  6. unindexed -> un-indexed
  7. unmanaged -> TODO: Look up context
  8. unminified -> un-minified (? – maybe de-minified)
  9. unmoderated -> un-moderated
  10. unpromote -> un-promote
  11. unpublish -> un-publish (? – check dictionary on this)
  12. unpublishing -> un-publishing (? - check dictionary on this)
  13. unrevisionable -> un-revisionable
  14. unrouted -> TODO: Look up context
  15. unserialized -> un-serialized
  16. unsets -> un-sets (? – check dictionary on this)
  17. unsetting -> un-setting (? – check dictionary on this)
  18. unsticky -> un-sticky
  19. untabbable -> TODO: Look up context
  • #3392740: Fix spelling of 5 'un' words in comments
    1. undoable -> TODO: Look up context
    2. unfieldable -> un-fieldable
    3. uninstallation -> un-installation
    4. uninstallations -> TODO: Look up context
    5. unpublishes -> un-publishes (? – check dictionary on this)
  • #3403211: Hyphenate 4 words that start with 'un'
    1. unsanitized -> un-sanitized
    2. unserialization -> un-serialization
    3. unserializes -> un-serializes
    4. unserializing -> un-serializing
  • #3409362: Fix spelling of some words with 'un' prefix
    1. unaliased
    2. unallowed
    3. unconfigured
    4. undelayed
    5. undraggable
    6. unextracted
    7. unflagged
    8. unhashed
    9. unhides
    10. unindented
    11. uninstantiatable
    12. uninstantiated
    13. unixepoch This is an SQLite function
    14. unixtimestamp
    15. unkeyed
    16. unmatch
    17. unpermissioned
    18. unpreloaded
    19. unrendered
    20. unshortened
    21. unsimplified
    22. untarring
    23. untrustable
  • #3412959: Fix 12 'un' words
    1. unassigning -> un-assigning
    2. unassigns -> un-assigns
    3. unbans -> TODO: Look up context
    4. unbundleable -> un-bundleable
    5. unclickable -> TODO: Look up context
    6. uncollapsible -> TODO: Look up context
    7. ungenerated -> TODO: Look up context
    8. unparseable -> un-parseable
    9. unpromoted -> un-promoted
    10. unregisters -> un-registers
    11. unvalidated -> TODO: Look up context
    12. unwrapper -> TODO: Look up context

Remaining tasks

  1. First, probably reduce the list above (as a non-native English speaker I couldn't remove all the 'obviously unhyphenated' words before posting here).
  2. Decide as a group what to do with each word.
  3. Remove and fix the words as defined by the group.
  4. Review.
  5. Commit.

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3265331

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

andregp created an issue. See original summary.

rootwork’s picture

Issue summary: View changes
Issue tags: +Novice, +Portland2022

Adding Novice tag for the first step under "remaining tasks".

Requires native English speaker.

Task: Look at the list of words above, and provide feedback about which should be hyphenated.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

cindytwilliams’s picture

Issue tags: -Portland2022 +Prague2022

Tagging this issue for first time contributors at DrupalCon Prague 2022.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

Issue tags: +cspell error
deanbowles’s picture

I think the general idea with the "un-" prefix is to not use a hyphen unless it aids clarity or readability, such as when there's a potential for misreading or ambiguity. In most uses, none of these words should be hyphenated.

xjm’s picture

@deanbowles, well, that is part of the reasoning; however, words like these become words through a productive morphological process in which a word is constructed from a bound morpheme prefix or suffix (like "un-"), and then if the new combination becomes a part of common parlance, gets backshifted and ends up in the dictionary without a hyphen. For example, consider that teenager was spelled as "teen-ager" in the 50s.

So, we will retain the scope currently as proposed for words starting with un- that are not misspellings of other words and that are not in our dictionary. A few words may need to be replaced with other phrases instead.

In no case can we leave the words as they are without doing some research or changing them where we're comfortable, because they are supposed to be English words but cspell does not accept them, so it's not in cspell-English.

bhumboldt’s picture

Assigned: Unassigned » bhumboldt

I plan to work on this issue with a team of Novice contributors with @xjm mentoring. We anticipate working on this this week and next week as well.

bhumboldt’s picture

Issue summary: View changes

Discussed this issue with @xjm, @allison-herodevs, @ashley_herodev. We went over the list of words starting with "un" that are currently in the dictionary. It seems like some issues should be handled in this scope as they need a hyphen, but some others might need separate child issues as they need more context or may need to be replaced with a different word. We will continue to work on this

xjm’s picture

Adding to #12, the IS has been updated with our initial thoughts.

bhumboldt’s picture

I wanted to give an update that we are still working on this and should have a more substantial update next week

xjm’s picture

Title: Fix missing hyphens for prefixes - Words starting with "un" » [meta] Fix missing hyphens for prefixes - Words starting with "un"
Category: Task » Plan
quietone’s picture

Issue summary: View changes
quietone’s picture

Issue summary: View changes
quietone’s picture

quietone’s picture

Issue summary: View changes
quietone’s picture

Issue summary: View changes
quietone’s picture

Issue summary: View changes

I think the remaining words are in code or user facing text.

sanket.tale made their first commit to this issue’s fork.

quietone’s picture

Assigned: bhumboldt » Unassigned

@sanket.tale, Welcome to Drupal! Take care when creating forks, this is a meta issue that does not need an MR. I urge you to read the Contribution Guide to help you find issues suited to your skills and interests.

sanket.tale’s picture

Hi @quietone Just getting started and learning how to contribute. I'll look over the documentation and identify the issue based on my skill set. Many thanks!

Chandansha made their first commit to this issue’s fork.

chandansha’s picture

Status: Active » Needs review

please review my small contribute if i am wrong please guide me.
Thanks!!

xjm’s picture

Status: Needs review » Active

@Chandansha, this is a "Plan" issue, which means we do not create merge requests against it. Instead, we make child issues for the individual tasks with different kinds of fixes according to our scope guidelines. Please don't create merge requests for a single word; furthermore, I would not recommend working on the child issues until we've fixed the plan for them. Thanks!

quietone’s picture

Issue tags: -Novice

Removing novice tag because the list is reduced to the one that are a bit harder and require some research.

quietone’s picture

Component: documentation » other

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.