Problem/Motivation

The Add heading button is not showing up in sections

Steps to reproduce

Give that a VLP page was created after a fresh Varbase 10.0.0-rc1 build and installation
When I go to editing the layout of the page
Then old and new created sections do not have the Add Heading action button
Before the fix

Proposed resolution

  • Fix the logic to work with cache or not cache
  • TEMP: Clear the cache after install with ./bin/drush cr

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-10.0.0-rc2, varbase_layout_builder-10.0.47, varbase-10.0.0-rc2, varbase_layout_builder-10.1.0-rc2

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

After the fix

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3408146 by impol: Fixed missing Add heading after fresh install, which needs a clear cache to show up in Layout editing
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Rajab Natshah created an issue. See original summary.

rajab natshah’s picture

Issue tags: +varbase-10.0.0
rajab natshah’s picture

Issue tags: -varbase-10.0.0 +varbase-10.0.0-rc2
rajab natshah’s picture

Issue tags: -varbase-10.0.0-rc2 +varbase-10.0.0

impol made their first commit to this issue’s fork.

rajab natshah’s picture

Status: Active » Needs review
rajab natshah’s picture

Thank you, Yauheni, for helping and debugging.

Your logic on this is better!

Having the better logic in the 10.0.x too.
moving the conditions in the class too.

Some Varbase ~9.1.0 sites may switch the default dashboard from Varbase Total Control Dashboard to Varbase Dashboards with Layout Builder

Doing the logic of only Bootstrap Layout Builder, or some front-end theme ( Bootstrap ).

I wish that Drupal has an API or some logic to let a module works only for the ^front-end theme
Hoping to find a better fix for this.

Copied part of our private Slack IMs

rajab natshah’s picture

Assigned: rajab natshah » Unassigned

  • Rajab Natshah committed 5fcaa767 on 10.1.x authored by impol
    Issue #3408146 by impol: Fix missing Add heading after fresh install of...

  • Rajab Natshah committed 89a6de47 on 10.0.x authored by impol
    Issue #3408146 by impol: Fix missing Add heading after fresh install of...
rajab natshah’s picture

Title: Fix missing Add heading after fresh install of VLP 10.1.x which needs a clear cache to show up in Layout editing » Fix missing Add heading after fresh install, which needs a clear cache to show up in Layout editing
Issue summary: View changes
Issue tags: +varbase-9.1.1, +varbase_layout_builder-10.0.47, +varbase_layout_builder-10.1.0-rc2
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Issue summary: View changes
Issue tags: -varbase-10.0.0 +varbase-10.0.0-rc2
rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-10.0.0-rc2

weldong’s picture

On fresh install of 10.0.0-rc2, add headings is in layoutbuilder, but varbase heading block module is not enabled by default. Suggest making module enabled by default or detect if module is enabled.