Problem/Motivation

In D10 drupal_dialog.off_canvas is changed and we need to change our code accordingly.

Follow up issue after #3401834: Fix Request-URI Too Long 414 for deep level 4 or 5+ AJAX requests

The current VarbaseLayoutBuilderThemeNegotiator logic and code is same like what is in the 10.1.x branch.
We may need to revert some of the logic in 10.0.x
if this change is doing more aggression issues

10.1.x

10.0.42

It was like this in 10.0.41

Proposed resolution

  • Remove $parent_theme_is_front_end_theme
  • Add isset($current_request['_drupal_ajax'])

Test if the logic will continue to work with Drupal 9 and Drupal 10 using the same codebase.

This will be fixed for Drupal ~10.1.0 for now
When Drupal 10.2.0 stable is released the #3348789: Compress ajax_page_state
will come in again, logic could be changed too by then.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-9.0.17, varbase-9.1.0, varbase_layout_builder-10.0.43

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3404615 by emircanerkul: Fixed not needed condition for parent theme is front-end theme and _drupal_ajax in Drupal ~10.1.0 compatibility of VarbaseLayoutBuilderThemeNegotiator
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

emircanerkul created an issue. See original summary.

rajab natshah’s picture

Title: Drupal 10 compatibility of VarbaseLayoutBuilderThemeNegotiator » Fix parent theme is front-end theme and _drupal_ajax in Drupal ~10.1.0 compatibility of VarbaseLayoutBuilderThemeNegotiator
Assigned: emircan erkul » Unassigned
Issue summary: View changes
Status: Active » Needs review
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Title: Fix parent theme is front-end theme and _drupal_ajax in Drupal ~10.1.0 compatibility of VarbaseLayoutBuilderThemeNegotiator » Fix not needed condition for parent theme is front-end theme and _drupal_ajax in Drupal ~10.1.0 compatibility of VarbaseLayoutBuilderThemeNegotiator

rajab natshah’s picture

Priority: Major » Normal
Issue summary: View changes
Issue tags: +varbase-9.0.17, +varbase-9.1.0, +varbase_layout_builder-10.0.43
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-9.0.17

rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-9.1.0

rajab natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.