There are at least two wrong wordings In node.views.inc:

  1. In the field definition of 'Node: Promote', the given help text is obviously wrong. 'Node: Promote' is not "The front page of the node." but the Promotion status. Changed this to "Whether or not the node is promoted to the front page."
  2. In the field definition of 'Node: Published or admin', the given label "Published" is also wrong. It needs to be "Published or admin" to avoid confusing it with the regular 'Node: Published'.
  3. In the field definition of 'Node: Published', the given help text might be a bit misleading. "The published status of the node." would probably be interpreted by most people as something like "The status that has been published" and not "The status defining if a node has been published". Only the latter is correct. I suggest to use the wording: "Whether or not the node is published." or "The publishing state of the node". The former has been rolled into my enclosed patch.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pancho’s picture

Title: Wrong wordings in node.views.inc » Wrong wordings in field implementations
FileSize
5.45 KB

There are two more incorrect wordings and some improvable ones in the field implementations for book, comment, search and user:

Search: Links from
The helptext "Nodes that link from the node." makes absolutely no sense. Suggestion: "Other nodes that are linked from the node."
Search: Links to
Add the word "other to the helptext, so it reads: "Other nodes that link to the node."
Users: E-mail
"This field is not normally shown to users" wold mean it is displayed differently. What was meant it indeed: "This field is normally not shown to users"
Book: Menu links
In the help text "The order of pages in the book hierarchy. Remember to sort by weight too if you want exactly the right order." the commata around "too" are missing which makes the text a bit hard to read. My suggestion: 'The order of pages in the book hierarchy. If you want the exactly right order, remember to sort by weight, too.'
Comment: Name
Help text: "The name of the poster." Elsewhere you use the wording "comment's author", using it here as well, would be consistent. Also added a note that the name can be rendered as a link to the author's homepage.
Comment: Homepage
Help text. "Can be a link." is a bit confusing, "Can be rendered as a link." should be more clear.
Also, "Will be empty if posted by a registered user." is a bit confusing, because registered users don't post their website address in comments. "Will be empty if the author is a registered user." should be slightly better.
Removed the sentence "The homepage can also be linked with the Name field." I understand that you wanted to point the admin to the 'Comment: Name' field, but it is completely confusing. We'd better add this information to the 'Comment: Name' helptext (as above).

Rolled everything into the enclosed patch.

merlinofchaos’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.