Problem/Motivation

Clicking escape gets rid of the loading animation but there is still an overflow:hidden style on the body that isnt reset.

Steps to reproduce

trigger the loading animation and click escape. Scrolling the page is disabled.

Proposed resolution

remove the overflow:hidden style from the body when the loader is closed.

In fact, there should be an unlockScreen() function that you can call from your own js for other events that should close it as well.

I will try to provide a patch for this.

CommentFileSizeAuthor
#2 scrolling-is-still-locked-issue-fixes-3395980.patch353 bytesviren18febs

Issue fork page_load_progress-3395980

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    About issue forks

    Comments

    loze created an issue. See original summary.

    viren18febs’s picture

    viren18febs commented
    Status: Active » Needs review
    StatusFileSize
    new scrolling-is-still-locked-issue-fixes-3395980.patch353 bytes

    Hi @loze
    I have fixed the issue & added a patch file , please review.

    damienmckenna’s picture

    damienmckenna
    Location TN, USA
    commented
    Status: Needs review » Reviewed & tested by the community

    I can confirm that patch #2 fixes the problem, thank you!

    i-trokhanenko’s picture

    i-trokhanenko
    Location Lutsk 🇺🇦
    commented
    Version: 2.0.0 » 2.0.x-dev

    • i-trokhanenko committed b026c90c on 2.0.x 
      Issue #3395980 by viren18febs, loze, damienmckenna, i-trokhanenko:...
    i-trokhanenko’s picture

    i-trokhanenko
    Location Lutsk 🇺🇦
    commented
    Status: Reviewed & tested by the community » Fixed

    Thanks!

    Status: Fixed » Closed (fixed)

    Automatically closed - issue fixed for 2 weeks with no activity.