Problem/Motivation

Since 7th of June, 2023, Drupal.org enabled GitLab CI for testing purposes. GitLab CI is now preferred over DrupalCI for testing. We need to remove DrupalCI testing once you have GitLab CI set up.

This issue is to track progress towards getting a .gitlab-ci.yml file so that we can migrate away from the deprecated DrupalCI to GitLab CI.

Proposed resolution

Add default .gitlab-ci.yml

Issue fork anchor_link-3395805

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Abyss created an issue. See original summary.

Abyss opened merge request !7

abyss’s picture

abyss commented
Status: Active » Needs review

Added the default .gitlab-ci.yml.
If necessary, some tasks can be disabled.
For example, since the module does not have phpunit tests, we can disable the phpunit check.
Let me know if we need to make any additional adjustments.

rajab natshah made their first commit to this issue’s fork.

rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs review » Needs work

  • rajab natshah committed 6ef9504a on 3.0.x 
    Issue #3395805: Remove DrupalCI testing and setup GitLab CI pipelines

  • rajab natshah committed 0a504512 on 3.0.x authored by abyss 
    Issue #3395805 by abyss: Remove DrupalCI testing and setup GitLab CI...
rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs work » Fixed
Issue tags: +anchor_link-3.0.0
rajab natshah’s picture

rajab natshah
he/him
commented

✅ Released anchor_link-3.0.0

willtomlinson’s picture

willtomlinson commented

This broke for me until I patched to lowercase TRUE, FALSE and NULL.

https://git.drupalcode.org/project/anchor_link/-/merge_requests/7/diffs?...

rajab natshah’s picture

rajab natshah
he/him
commented

Is that for CKEditor 4?
It should be fixed, you are right.
Please, file a new issue, and we will follow up with that for sure.

rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: Unassigned » rajab natshah
Status: Fixed » Active

Re-opning the issue

  • rajab natshah committed e1ef384f on 3.0.x 
    Issue #3395805 by willtomlinson: Fix: Use lowercase true, false, and...
rajab natshah’s picture

rajab natshah
he/him
commented

✅ Released anchor_link 3.0.2

  • Issue #3395805 by willtomlinson: Fixed to use lowercase true, false, and null to prevent breaking in old CKEditor 4
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: rajab natshah » Unassigned
Status: Active » Fixed
Issue tags: +anchor_link-3.0.2
rajab natshah’s picture

rajab natshah
he/him
commented
Status: Fixed » Closed (fixed)