Problem/Motivation

Restructure site-header into templates, menu element will be seperated into a dedicated component
Create regions file within global dir to house site-header & site-footer styles

Issue fork prototype-3387385

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jldust created an issue. See original summary.

jldust opened merge request !62

jldust’s picture

jldust commented
Status: Active » Needs review

This is a major rework of the site-header and menu structure supported by Prototype. With this we have created a reusable menu component that supports out of the box accessibility and needs additional testing.

philip_stier’s picture

philip_stier commented

@jldust - As mentioned, I can help transpose this into Vanilla JavaScript, but looks good for now :)

jldust’s picture

jldust commented
Status: Needs review » Reviewed & tested by the community

Thanks for reviews, I've merged this in and it will be included in the next tagged release.

jldust opened merge request !63

jldust’s picture

jldust commented
Status: Reviewed & tested by the community » Fixed
jldust’s picture

jldust commented
Status: Fixed » Closed (fixed)

This has been included in the 5.x.2-alpha1 releases.

jldust closed merge request !63