Problem/Motivation

MenuUiNodeTest uses a form submission to change language settings.

This is expensive, and not what the test is covering.

Steps to reproduce

Proposed resolution

Change to API calls.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 replace_ui_by_api-3385834-2.patch2.99 KBvbouchet

Comments

joachim created an issue. See original summary.

vbouchet’s picture

vbouchet
Location Toulouse
commented
Status: Active » Needs review
StatusFileSize
new replace_ui_by_api-3385834-2.patch2.99 KB
joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

Looks good!

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » 10.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 7a84619f63 to 11.x and c5444ac62a to 10.2.x and f78f93b941 to 10.1.x. Thanks!

  • longwave committed f78f93b9 on 10.1.x 
    Issue #3385834 by vbouchet, joachim: MenuUiNodeTest should use API to...

  • longwave committed c5444ac6 on 10.2.x 
    Issue #3385834 by vbouchet, joachim: MenuUiNodeTest should use API to...

  • longwave committed 7a84619f on 11.x 
    Issue #3385834 by vbouchet, joachim: MenuUiNodeTest should use API to...
needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Fixed » Needs work

The Needs Review Queue Bot tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.