Problem/Motivation

ContactLanguageTest uses a form submission to change language settings.

This is expensive, and not what the test is covering.

Steps to reproduce

Proposed resolution

Change to an API call.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 use_api_instead_of_ui-3384935-2.patch1.42 KBvbouchet

Comments

joachim created an issue. See original summary.

vbouchet’s picture

vbouchet
Location Toulouse
commented
Status: Active » Needs review
StatusFileSize
new use_api_instead_of_ui-3384935-2.patch1.42 KB
joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

Looks good!

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Version: 11.x-dev » 10.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 8c01b91e20 to 11.x and 9260579dde to 10.2.x and e02f739e37 to 10.1.x. Thanks!

  • longwave committed e02f739e on 10.1.x 
    Issue #3384935 by vbouchet: ContactLanguageTest should use API to set up...

  • longwave committed 9260579d on 10.2.x 
    Issue #3384935 by vbouchet: ContactLanguageTest should use API to set up...

  • longwave committed 8c01b91e on 11.x 
    Issue #3384935 by vbouchet: ContactLanguageTest should use API to set up...
needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Fixed » Needs work

The Needs Review Queue Bot tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.