Problem/Motivation

Disabling the padding or margin plugins creates a JS error when spacing.padding_classes_options or spacing.margin_classes_options is not set in spacing-preview.js

Steps to reproduce

  1. Disable Padding or Margin plugins
  2. Try to edit a section or block

Proposed resolution

Add checks in JS.

CommentFileSizeAuthor
bootstrap_styles_disabled_padding_margin.patch5.51 KBgordonio

Issue fork bootstrap_styles-3376918

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    About issue forks

    Comments

    gordonio created an issue. See original summary.

    kmonty’s picture

    kmonty
    He/Him
    Location Berlin, DE + SF, CA
    commented

    Note: our team similarly encountered this issue. This patch resolved it.

    rollins’s picture

    rollins commented
    Status: Active » Reviewed & tested by the community

    +1 for the patch.
    We had the same issue with disabling the padding/margin plugins, which creates a JS error
    Patch works properly

    thank you @gordonio

    rajab natshah’s picture

    rajab natshah
    he/him
    commented
    Version: 1.1.0 » 1.2.x-dev

    • rajab natshah committed be5a861a on 1.2.x 
      feat: #3376918 Disabling margin or padding plugins causing JS error - By...
    rajab natshah’s picture

    rajab natshah
    he/him
    commented
    Issue tags: +bootstrap_styles-1.2.3
    rajab natshah’s picture

    rajab natshah
    he/him
    commented
    Status: Reviewed & tested by the community » Fixed

    Now that this issue is closed, review the contribution record.

    As a contributor, attribute any organization that helped you, or if you volunteered your own time.

    Maintainers, credit people who helped resolve this issue.

    rajab natshah’s picture

    rajab natshah
    he/him
    commented

    ✅ Released bootstrap_styles-1.2.3

    Status: Fixed » Closed (fixed)

    Automatically closed - issue fixed for 2 weeks with no activity.