Problem/Motivation

While working on #3374547, the pipelines passed, but only because sniffer violations were allowed to fail.

Drupal 8 has been end of life for quite some time:
https://www.drupal.org/psa-2021-11-30

Steps to reproduce

See https://git.drupalcode.org/project/layout_builder_additions/-/jobs/57630 for the code sniffer violation.

Proposed resolution

  • Fix the code sniffer issue
  • Remove Drupal 8.7.7 from the core version requirement in the project's info.yml file.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork layout_builder_additions-3374550

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rklawson created an issue. See original summary.

rklawson’s picture

rklawson commented
Title: Fix code sniffer violation and drop Drupal 8 » Fix phpcs violation and drop Drupal 8
Status: Active » Fixed

Updates

  • Resolved the phpcs error. Pipelines now fully pass.
  • Dropped Drupal 8 support in the info.yml file.
rklawson’s picture

rklawson commented
Status: Fixed » Closed (fixed)

Closing this out as fixed.