Problem/Motivation

Having a light mod Layout Builder off canvas, with dark mixed mode

Proposed resolution

  • Add an only administrative behavior to add the Gin dark mode to the Drupal off canvas.
  • Even tho if the user is using the Gin light mode.

Add the gin--dark-mode class to the #drupal-off-canvas or #drupal-off-canvas-wrapper only once.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release Varbase 10.0.0-beta1, varbase_layout_builder-10.1.0-alpha6

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

After the fix:

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3373881: Added the Gin dark mode to the Drupal off canvas for Layout Builder. Even tho if the user was using the Gin light mode at the back-end

Comments

Rajab Natshah created an issue. See original summary.

  • Rajab Natshah committed c36d552f on 10.1.x
    Issue #3373881: Add the Gin dark mode to the Drupal off canvas for...
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

  • Rajab Natshah committed a5cd38e8 on 10.1.x
    Issue #3373881: Add the Gin dark mode to the Drupal off canvas for...

  • Rajab Natshah committed 728b1085 on 10.1.x
    Issue #3373881: Add the Gin dark mode to the Drupal off canvas for...
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Assigned: rajab natshah » Unassigned
Issue summary: View changes
Status: Active » Needs review
Issue tags: +varbase-10.0.0-beta1, +varbase_layout_builder-10.1.0-alpha6
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Title: Add the Gin dark mode to the Drupal off canvas for Layout Builder. even tho if the user was using the Gin light mode at the back-end » Add the Gin dark mode to the Drupal off canvas for Layout Builder. Even tho if the user was using the Gin light mode at the back-end
Issue summary: View changes
rajab natshah’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Issue summary: View changes