Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new984 bytes

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.15.1, cannot fix all Drupal 10 compatibility problems.

Therefore this patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #12554

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.35
  2. palantirnet/drupal-rector: 0.15.1

suresh7787 made their first commit to this issue’s fork.

Watergate changed the visibility of the branch 3369369-automated-drupal-10-1 to hidden.

Watergate changed the visibility of the branch 3369369-automated-drupal-10-1 to active.

Watergate changed the visibility of the branch 3369369-automated-drupal-10 to hidden.

watergate’s picture

Issue summary: View changes

I looked into this issue to get this module working with Drupal 10. While updating/applying the patch provided by the Project Update Bot in the issue fork, I noticed that in #3315629: Remove deprecated MediaRevisionAccessCheck in Drupal 10, the core_version_requirement already had been updated, but this is not included in a release yet.

watergate’s picture

mingsong’s picture

Thanks @Niels for looking into it.

Yes, that is right. That patch has been merged into the develop branch.

As I explained in #11The reason why no release for it is that the change involved access checking, in other words, it requires a security review closely. Develop version means not ready for production yet, but for testing.

watergate’s picture

@Mingsong, thanks for your reply. I understand your point that "dev"-versions shouldn't be used in production. But the functionality of #3315629: Remove deprecated MediaRevisionAccessCheck in Drupal 10, which has been merged already, is blocking a Drupal 10-compatible release for this module.

I propose rolling back the functionality that needs explicit testing, using that to create a Drupal 9 and 10 compatible release, and tagging it as 1.1.0. In combination, make a 2.0.0-alpha1 version compatible with Drupal 10 (and 9?), which contains the functionality that needs explicit testing. We can then use the project page and release notes to point users for feedback on the changed functionality (that is included as an alpha release).

Please let me know if you agree with the above proposition and need help.

For others who want to install this module in Drupal 10, I've attached a small patch to this issue, which can be used with the mglaman/composer-drupal-lenient and orakili/composer-drupal-info-file-patch-helper Composer plugins to ease Drupal10 upgrade.

mingsong’s picture

This module has been looking for a maintainer to take over, who will be in charge of D10 versions and beyond.

watergate’s picture

@Mingsong, you can add me as a maintainer. I will create the Drupal 10 compatible release and help where needed.

mingsong’s picture

@Niels, thanks for offering the help.

I just sent you an email to discuss your kind help.

Looking forward to hearing from you.

watergate’s picture

I have updated the merge-request, by reverting the commit that changed the access checking. So that we can create a Drupal 10 compatible release using the 1.0.x branch, and continue the work for new functionality on the 2.x branch.

  • Watergate committed 9f365d2d on 1.0.x
    Issue #3369369 by Watergate, Project Update Bot, Mingsong: Automated...
watergate’s picture

watergate’s picture

Status: Needs review » Fixed

Changes are merged.

watergate’s picture

Assigned: Unassigned » watergate
Status: Fixed » Active

Sorry, I now understand that the Media diff UI plugin sub-module uses deprecated functionality in Drupal 10. I will, therefore, change the core_version_requirement for that specific sub-module. In case the Media diff UI plugin sub-module is needed in a Drupal 10 installation, the 2.0.0-alpha1 version of this module can be used, but the introduced access changes should be reviewed closely (as indicated in #3369369-11: Automated Drupal 10 compatibility fixes).

Watergate changed the visibility of the branch 1.0.x to hidden.

Watergate changed the visibility of the branch 2.x to hidden.

watergate’s picture

Assigned: watergate » Unassigned
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.