Installing Content Translation module breaks Rest resources

@SenthilMohith thank you for the interest but shouldn't assign tickets to yourself unless a maintainer per https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett...

queuing for 11.x tests.

Tests all green.

Also ran a test locally without the fix file and the testGet() failed with

Drupal\Component\Plugin\Exception\PluginNotFoundException : The "drupal:content-translation-overview" plugin does not exist. Valid plugin IDs for Drupal\Core\Http\LinkRelationTypeManager are: add-form, add-page, delete-form, delete-multiple-form, revision, revision-revert-form, revision-delete-form, create, enable, disable, edit-permissions-form, overview-form, reset-form, cancel-form, flush-form, duplicate-form, about, alternate, appendix, archives, author, blocked-by, bookmark, canonical, chapter, collection, contents, copyright, create-form, current, customize-form, derivedfrom, describedby, describes, disclosure, dns-prefetch, duplicate, edit, edit-form, edit-media, enclosure, first, glossary, help, hosts, hub, icon, index, item, last, latest-version, license, lrdd, memento, monitor, monitor-group, next, next-archive, nofollow, noreferrer, original, payment, pingback, preconnect, predecessor-version, prefetch, preload, prerender, prev, preview, previous, prev-archive, privacy-policy, profile, related, replies, search, section, self, set-default, service, start, stylesheet, subsection, successor-version, tag, terms-of-service, timegate, timemap, type, up, version-history, via, webmention, working-copy, working-copy-of, entity-permissions-form

Think this is good.

+++ b/core/modules/content_translation/content_translation.link_relation_types.yml
@@ -0,0 +1,14 @@
+drupal:content-translation-overview:
...
+drupal:content-translation-add:
...
+drupal:content-translation-edit:
...
+drupal:content-translation-delete:

Why are these prefixed with drupal:? No other Drupal-specific link relations have this prefix.

True. Moving to NW to update links.

Going to put in committer bucket to get more eyes on it.

Not sure I could make the call.

I'm triaging RTBC issues. I read the IS and the comments.

Thanks for answering longwave's query. Due to the adding of the prefix, this should have subsystem maintainer review first (I checked with xjm)

Oh I see:

        if (!$entity_type->hasLinkTemplate('drupal:content-translation-overview')) {
          $translations_path = $entity_type->getLinkTemplate('canonical') . '/translations';
          $entity_type->setLinkTemplate('drupal:content-translation-overview', $translations_path);
          $entity_type->setLinkTemplate('drupal:content-translation-add', $translations_path . '/add/{source}/{target}');
          $entity_type->setLinkTemplate('drupal:content-translation-edit', $translations_path . '/edit/{language}');
          $entity_type->setLinkTemplate('drupal:content-translation-delete', $translations_path . '/delete/{language}');
        }

So we already declare these link templates - this code has existed since 8.0. But we didn't define the metadata for them, which REST module requires. Changing these now would break backward compatibility with code that already uses them, which is out of scope of this issue.

The Needs Review Queue Bot tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request. Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

OK @tstoeckler's explanation means we don't need subsystem maintainer review, just a misunderstanding about the links already existing (which I also would have done probably).

Committed/pushed to 11.x and cherry-picked back through to 10.3.x, thanks!

Belatedly crediting myself for release management review, and @quietone for asking the question.