Problem/Motivation

Running sonarqube we found this issue on ln 747of BetterExposedFilters.php: Make sure that the referenced value variable is unset after the loop.
Why is this a problem?
When a reference is used in a foreach loop instead of using a simple variable, the reference remains assigned and keeps its "value" which is a reference, even after the foreach execution. Most of the time, this is not what the developer is expecting and the reference may be used wrongly in the rest of the code. For this reason, it is recommended to always unset a reference that is used in a foreach to avoid any unexpected side effects.

Steps to reproduce

The proposed solution is remove the reference from de variable

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork better_exposed_filters-3367019

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

paucala created an issue. See original summary.

paucala opened merge request !37

paucala’s picture

paucala commented
Status: Active » Needs review

smustgrave made their first commit to this issue’s fork.

smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.