Problem/Motivation

After updating to Drupal 10, the following error is thrown:
PHP Fatal error: Declaration of Drupal\total_control\Routing\RouteSubscriber::getSubscribedEvents() must be compatible with Drupal\Core\Routing\RouteSubscriberBase::getSubscribedEvents(): array in /var/www/html/web/modules/contrib/total_control/src/Routing/RouteSubscriber.php on line 26

Proposed resolution

  • Add : array to be compatible with RouteSubscriberBase

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ✅ Automated unit testing coverage
  • ✅ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ➖ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Documentation
  • ✅ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release notes snippet
  • ✅ Release total_control-3.0.4

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3366999 by mrcdrx: Fixed Fatal error after Drupal 10 upgrade with Total Control Admin Dashboard
CommentFileSizeAuthor
#7 Screenshot 2023-06-22 at 4.49.05 PM.png156.43 KBshobhit_juyal
#4 3366999-fatal-error-after.patch534 bytesmrcdrx

Issue fork total_control-3366999

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mrcdrx created an issue. See original summary.

mrcdrx opened merge request !2

mrcdrx’s picture

mrcdrx commented
Priority: Major » Critical
mrcdrx’s picture

mrcdrx commented
StatusFileSize
new 3366999-fatal-error-after.patch534 bytes

Added patch file for anyone who needs it.

mrcdrx’s picture

mrcdrx commented
Status: Active » Needs review
jeroen dost’s picture

jeroen dost commented

Applying the patch from #4 fixes the problem for me.

shobhit_juyal’s picture

shobhit_juyal commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screenshot 2023-06-22 at 4.49.05 PM.png156.43 KB

Patch is tested and working fine for me and #6. Drupal version - 10.1.0

Moving this to RTBC.

Thanks
mrcdrx

rajab natshah’s picture

rajab natshah
he/him
commented

Thanks, Marc, for reporting and the MR/Patch fix. Also Jeroen and Shobhit for reviewing
I confirm having the issue with Drupal 10

rajab natshah’s picture

rajab natshah
he/him
commented
Title: Fatal error after Drupal 10 upgrade » Fix Fatal error after Drupal 10 upgrade with Total Control Admin Dashboard
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

  • Rajab Natshah committed 87504622 on 3.0.x authored by mrcdrx 
    Issue #3366999 by mrcdrx: Fix Fatal error after Drupal 10 upgrade with...
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: Unassigned » mohammed j. razem
Issue summary: View changes
Issue tags: +Drupal 10 compatibility, +total_control-3.0.4
rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

rajab natshah
he/him
commented
Status: Reviewed & tested by the community » Fixed
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes

✅ Released total_control-3.0.4

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mrcdrx’s picture

mrcdrx commented