Problem/Motivation

We forgot to add an update hook in #3356063: image_captcha_update_9002 incorrectly updated image_captcha instead of captcha title to notify the user, that their custom captcha title will be replaced with "Captcha". Let's implement the update hook here.

Steps to reproduce

Proposed resolution

Implement the update hook.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork captcha-3365278

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grevil created an issue. See original summary.

Grevil opened merge request !66

grevil’s picture

grevil commented
Status: Active » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

Indeed I made a mistake in #3356063: image_captcha_update_9002 incorrectly updated image_captcha instead of captcha title. It shouldn't have got RTBC'd. Instead the old title should have been read onto a variable and set for the new variable.

So I reverted that change, that was never released and only part of 2.x-dev for some minutes. Let's fix and test it here finally. Thanks for the correction @Grevil.

grevil’s picture

grevil commented
Related issues: +#3356063: image_captcha_update_9002 incorrectly updated image_captcha instead of captcha title
grevil’s picture

grevil commented
Status: Needs work » Needs review

Done, please review!

grevil’s picture

grevil commented
Related issues: +#3321861: Change image_captcha submodule and test modules location.

We accidentally added update hook 9002 inside image_captcha instead of captcha inside #3321861: Change image_captcha submodule and test modules location.. This patch will also resolve that problem.

grevil’s picture

grevil commented

Pleae review!

grevil’s picture

grevil commented

Both newly added update hooks apply cleanly and after update, the incorrect image_captcha config key doesn't exist any more AND the previously set custom title is used again!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » anybody

Reviewing!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: anybody » Unassigned
grevil’s picture

grevil commented
Status: Needs review » Reviewed & tested by the community

Update hook works as expected. RTBC!

  • Grevil committed 53b5dde1 on 2.x 
    Issue #3365278: [Follow-up] image_captcha_update_9002 incorrectly...
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.