Problem/Motivation

Moving the submodule "image_captcha" from "captcha/image_captcha" to "captcha/modules/image_captcha" leads to a lot of problems for already existing captcha installations.

Steps to reproduce

Proposed resolution

I suggest we move the submodule folder back to its original spot, even if this isn't Drupal Best Practice.
We could also tag the 2.x release with a "Breaking Change" tag, but I think this isn't necessarily the best approach here.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork captcha-3321861

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grevil created an issue. See original summary.

Anybody made their first commit to this issue’s fork.

Anybody opened merge request !22

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil

Just added a MR for 2.x which might allow that change without breaking things.
Eventually we'll have to add a cache clear for the moved module!

BTW I just saw the _test modules in the modules directory. Is that correct? Or do these belong somewhere else (in tests...?)

grevil’s picture

grevil commented
Title: Change image_captcha submodule location. » Change image_captcha submodule and test modules location.

@Anybody, thanks for the heads-up! The location for the test modules is definitly incorrect! Test modules should always reside in "my_module/tests/modules/my_module_test"

grevil’s picture

grevil commented

@Anybody, also thanks for the MR! I will test it soon! If this works, that would be definitely the best approach!

grevil’s picture

grevil commented
Status: Active » Needs review

Update hook works great! Added NULL checks and a further tiny update hook.

Please review!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

LGTM! All fine

grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Perfect, all tests pass, pushing this to dev!

  • Anybody committed 75bf339 on 2.x 
    Issue #3321861 by Grevil, Anybody: Change image_captcha submodule and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.