Problem/Motivation

See: #3271278: Using ace editor with field ui throws error

Proposed resolution

Fix get of default settings in field ui

Remaining tasks

  • File an issue
  • Patch/MR
  • Review
  • Test
  • Release ( Quick fix release )

User interface changes

Fields with ACE editor, can be used in both Form Display and Entity Display

API changes

  • N/A

Data model changes

  • N/A
CommentFileSizeAuthor
#7 ace_editor_display_field_output_after.png161.26 KBtasneem natshah
#7 ace_editor_display_field_settings_after.png75.5 KBtasneem natshah
#7 ace_editor_display_field_output_before.png255.46 KBtasneem natshah
#7 ace_editor_display_field_settings_before.png67.12 KBtasneem natshah

Issue fork ace_editor-3365101

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sgurlt created an issue. See original summary.

mortona2k made their first commit to this issue’s fork.

mortona2k opened merge request !11

mortona2k’s picture

mortona2k commented

That looks like a mistake. We just need 

$config = \Drupal::config('ace_editor.settings')->get();

My IDE says $this can't be accessed because it's in a static function. I'm not sure how to access the configFactory from the container here.

MukhtarM made their first commit to this issue’s fork.

mukhtarm’s picture

mukhtarm commented
Status: Active » Needs review

Addressed the #4 in MR

tasneem natshah’s picture

tasneem natshah commented
StatusFileSize
new ace_editor_display_field_settings_before.png67.12 KB
new ace_editor_display_field_output_before.png255.46 KB
new ace_editor_display_field_settings_after.png75.5 KB
new ace_editor_display_field_output_after.png161.26 KB

I'm facing the same issue

Thanks for the patch

Before the patch:
Manage display field settings:
Ace editor display field settings before

Manage display field output:
Ace editor display field output before

After the patch:
Manage display field settings:
Ace editor display field settings after

Manage display field output:
Ace editor display field output after

rajab natshah’s picture

rajab natshah
he/him
commented
Priority: Normal » Critical
rajab natshah’s picture

rajab natshah
he/him
commented
Title: Reopen: Using ace editor with field ui throws error » Fix using ace editor with field ui throws error

rajab natshah’s picture

rajab natshah
he/him
commented
Issue summary: View changes
Status: Needs review » Fixed
Issue tags: +ace_editor-2.0.0-beta1

Committed ... Thank you :)

rajab natshah’s picture

rajab natshah
he/him
commented

✅ Released ace_editor-2.0.0-beta1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.