Problem/Motivation

Hello Project Maintainers, Creating this issue to help make module Drupal 10 Compatible.

Created patch for making module D10 compatible. There is one existing issue (core/popperjs library is deprecated in D9.5.0 and is removed in D10.0.0. https://www.drupal.org/node/3307518. Attached screenshot for reference.

CommentFileSizeAuthor
#13 hard_remove_ckeditor4_dependency.patch839 bytesajeet_kumar
#8 functionality.PNG7.45 KBabhinavk
#8 after_patch.PNG6.78 KBabhinavk
#8 before_patch.PNG7.92 KBabhinavk
#6 tooltip_d10-3358452-6.patch19.7 KBrahul17
#5 tooltip_d10-3358452-5.patch20.12 KBrahul17
#2 d10_compatibility.patch848 byteschandra gowsalya kannan
AfterPatchUpgradeStatus.png7.51 KBchandra gowsalya kannan
drupalCheck.txt1.21 KBchandra gowsalya kannan
ConsolePopper.png35.43 KBchandra gowsalya kannan
configSet.jpg92.84 KBchandra gowsalya kannan
AddTooltipButton-D10.jpg90.22 KBchandra gowsalya kannan
d10_compatibility.patch848 byteschandra gowsalya kannan

Issue fork tooltip-3358452

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Chandra Gowsalya Kannan created an issue. See original summary.

chandra gowsalya kannan’s picture

chandra gowsalya kannan commented
StatusFileSize
new d10_compatibility.patch848 bytes

This patch makes module D10 compatible.

dineshkumarbollu made their first commit to this issue’s fork.

dineshkumarbollu’s picture

dineshkumarbollu commented
Status: Needs review » Needs work

Hi

The patch is applied cleanly but it found 1 error while running "drush upgrade_status:analyze tooltip"

vendor/bin/drush upgrade_status:analyze tooltip
[notice] Processing /var/www/html/vbd9/web/modules/contrib/tooltip-3358452.

================================================================================
Tooltip, --
Scanned on Mon, 05/08/2023 - 13:04

FILE: web/modules/contrib/tooltip-3358452/tooltip.libraries.yml

STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 0 The 'tooltip' library is depending on a deprecated library.
The "core/popperjs" asset library is deprecated in Drupal
9.5.0 and will be removed in Drupal 10.0.0. There is no
replacement. See https://www.drupal.org/node/3307518
--------------------------------------------------------------------------------

rahul17’s picture

rahul17 commented
Assigned: Unassigned » rahul17
Status: Needs work » Needs review
StatusFileSize
new tooltip_d10-3358452-5.patch20.12 KB

Created patch to resolve deprecated library issue. Kindly review it.

rahul17’s picture

rahul17 commented
StatusFileSize
new tooltip_d10-3358452-6.patch19.7 KB

Ignore patch #5 uploaded wrong patch by mistake.

Uploading new patch this will work. Please review it.

rahul17’s picture

rahul17 commented
Assigned: rahul17 » Unassigned
abhinavk’s picture

abhinavk commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before_patch.PNG7.92 KB
new after_patch.PNG6.78 KB
new functionality.PNG7.45 KB

I have tested Patch #6 in Drupal 10.0.9 and it makes module compatible. Functionality is also working fine for me.
Moving to RTBC.

siddharthjain’s picture

siddharthjain commented

As per this article(https://www.drupal.org/node/3307518) the core/popperjs is deprecated in Drupal 10, so we need to implement ckeditor tooltip using Floating UI library in Drupal 10

siddharthjain’s picture

siddharthjain commented
Status: Reviewed & tested by the community » Needs work
matthieuscarset’s picture

matthieuscarset commented
Related issues: +#3284957: Add support for CKEditor5
matthieuscarset’s picture

matthieuscarset commented
Status: Needs work » Needs review

This issue is fixed by the latest release 1.1.1.

Needs review.

The popperjs library is now required within this module on branch 1.1.x.

New dependency to drupal/ckeditor contrib module to continue to use CKEditor version 4.

NB: Compatibilty with CKEditor5 is out-of-scope for this issue.

ajeet_kumar’s picture

ajeet_kumar
Primary language English
commented
StatusFileSize
new hard_remove_ckeditor4_dependency.patch839 bytes