Problem/Motivation

When on the Overview for Roles, you can click "Edit permissions" as an operation for roles. However, when you edit a Role you cannot access "Edit permissions." This route should be added as a local task. I constantly click "Edit" when I need "Edit permissions"

Related to #393406: "Edit" links on roles admin page are confusing to users: "Edit permissions" should be the primary link. But that doesn't solve the dead end for users.

Steps to reproduce

Edit role
Try to edit its permissions.

Proposed resolution

Add "Edit permissions" route as local task for the role

Remaining tasks

User interface changes

Extra local task added on role edit form.

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 Screenshot 2023-05-02 at 4.04.32 PM.png173.44 KBmglaman

Issue fork drupal-3355403

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mglaman created an issue. See original summary.

mglaman opened merge request !3910

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
StatusFileSize
new Screenshot 2023-05-02 at 4.04.32 PM.png173.44 KB

Result

andy-blum’s picture

andy-blum
he/him/his
Primary language English
Location Ohio, USA
commented

while we're at it can we add a JS search box that filters the massive table down to the items that have matching text a la permissions_filter?

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Issue tags: +Needs tests

Needs test to verify the UI changes.

@andy-blum seems like a good follow up

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative

Verified applying MR that on "admin/people/roles/manage/anonymous" there is a "Permissions" tab now.

Moving to NW for the tests mentioned.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
Issue tags: -Needs tests

Added the test!

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I agree, this is a good improvement.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

  • lauriii committed 80aa96f1 on 11.x 
    Issue #3355403 by mglaman: Add "Edit permisisons" as local task on role...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 11.x-dev » 10.1.x-dev

Committed 80aa96f and pushed to 11.x. Thanks!

Keeping open for potential 10.1.x backport. As a feature request this wouldn't qualify for the backport during RC but since this is a usability issue, it could have been filed as a bug too.

  • lauriii committed 82ddd55f on 10.1.x 
    Issue #3355403 by mglaman: Add "Edit permisisons" as local task on role...

lauriii closed merge request !3910

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Discussed with @catch and decided to backport because this only needs to add a new local task, and as such is low risk.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.