In ParagraphsFeatures.php starting on line 57

    if (!in_array(\Drupal::theme()->getActiveTheme()->getName(),
      ['claro', 'gin'])) {
      return;
    }

Is there a reason why this is locked down to those 2 themes or should those lines be deleted?

CommentFileSizeAuthor
#18 3353704-mr12-18.patch807 bytesosopolar
#17 3353704-13.patch1.84 KBosopolar

Issue fork paragraphs_features-3353704

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bletch created an issue. See original summary.

bletch opened merge request !10

bletch closed merge request !10

bletch opened merge request !11

bletch closed merge request !11

bletch opened merge request !12

bletch’s picture

bletch commented

Please ignore MR 10 & 11 - they went weird. 12 is correct.

bletch’s picture

bletch commented
Title: Add-in only work if active theme is claro or gin » Add-in only works if active theme is claro or gin
duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Version: 2.0.0-beta2 » 2.x-dev

I don't know if removing this test is relevant but it should at least pass even if our theme is a subtheme of one of these two.
Plus, the same test is used in \Drupal\paragraphs_features\ParagraphsFeatures::getThirdPartyForm() too so I suppose it should be changed accordingly.

DuaelFr opened merge request !13

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Active » Needs review

There you go

grzesag’s picture

grzesag commented

MR12 works for me when using with Seven administration theme, thanks

nishruu’s picture

nishruu commented

MR13 works for me with a subtheme of claro. Merci DuaelFr !

markconroy’s picture

markconroy commented
Status: Needs review » Reviewed & tested by the community

MR13 solved the issue for me.

Anonymous’s picture

Anonymous (not verified) commented

MR 13 does not solve https://www.drupal.org/project/paragraphs_features/issues/3374777

fisherman90’s picture

fisherman90
Primary language German
Location Dortmund
commented

I came here, because I'm using seven in a project, too. Was wondering really, why the code tests against certain admin themes?

For me MR12 sounds like the solution, if nobody can name a reason to limit the functionality to those themes.
Works at least for me for now :)

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented
StatusFileSize
new 3353704-13.patch1.84 KB

Copy of patch from MR13 attached, to be used with composer, see "Patches from drupal.org merge request URLs are dangerous?".
Edit: Sorry, but the patch naming was not correct, it's not related to #13 but to MR13.

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3353704-mr12-18.patch807 bytes

Currently we are using the Thunder Admin Theme, which is based on seven. After upgrading from 1.x to 2.x our Paragraphs Features stopped working due to this issue. As fisherman90 pointed out, it might not be necessary to limit the widget features to claro and gin (based) themes – or at least it would be nice to enable the widget also for other themes. Therefor I set the issue to needs work.

Copy of patch from MR12 attached, to be used with composer, see "Patches from drupal.org merge request URLs are dangerous?".

droprocker’s picture

droprocker commented

It would be nice to have this info on the module page itself. It could save a lot of time figuring out why it isn't working with custom or other themes.